Pass ShortcutHelper.EXTRA_SOURCE when WebAPK is launched from notification

Pass ShortcutHelper.EXTRA_SOURCE when WebAPK is launched from notification

This enables us to keep track of how often WebAPKs are launched from a
notification vs from the home screen.

BUG=623216
Committed: https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f
Cr-Commit-Position: refs/heads/master@{#403307}

[pkotwicz, 2016-06-26 00:09:38]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-06-26 00:10:04]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-06-26 00:10:05]

Xi can you please take a look?

[Xi Han, 2016-06-27 13:45:20]

lgtm

[pkotwicz, 2016-06-28 15:20:12]

pkotwicz@chromium.org changed reviewers:
+ peter@chromium.org

[pkotwicz, 2016-06-28 15:20:13]

Peter Beverloo can you please take a look?

[Peter Beverloo, 2016-06-28 23:09:24]

lgtm

https://codereview.chromium.org/2094113002/diff/20001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2094113002/diff/20001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:72:
int source = intent.getIntExtra(EXTRA_SOURCE, 0);
nit: any way we could use ShortcutSource.UNKNOWN here, rather than the `0`
literal?

[pkotwicz, 2016-06-30 20:49:26]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-06-30 20:49:27]

dfalcantara@ for OWNER rubberstamp

https://codereview.chromium.org/2094113002/diff/20001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2094113002/diff/20001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:72:
int source = intent.getIntExtra(EXTRA_SOURCE, 0);
Unfortunately not. MainActivity cannot depend on anything in //chrome (For
instance it cannot depend on //base)

[pkotwicz, 2016-06-30 20:49:27]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-06-30 20:49:27]

dfalcantara@ for OWNER rubberstamp

[gone, 2016-06-30 20:52:04]

lgtm

[pkotwicz, 2016-06-30 20:56:46]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:04:00]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-06-30 22:04:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 22:05:24]

Description was changed from

==========
Pass ShortcutHelper.EXTRA_SOURCE when WebAPK is launched from notification

This enables us to keep track of how often WebAPKs are launched from a
notification vs from the home screen.

BUG=623216
==========

to

==========
Pass ShortcutHelper.EXTRA_SOURCE when WebAPK is launched from notification

This enables us to keep track of how often WebAPKs are launched from a
notification vs from the home screen.

BUG=623216

Committed: https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f
Cr-Commit-Position: refs/heads/master@{#403307}
==========

[commit-bot: I haz the power, 2016-06-30 22:05:25]

Patchset 1 (id:??) landed as
https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f
Cr-Commit-Position: refs/heads/master@{#403307}