Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2094033002: capping how many times background download resumption can automatically start (Closed)

Created:
4 years, 6 months ago by qinmin
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

capping how many times background download resumption can automatically start If download gets interrupted due to browser kill, we schedule a browser restart. And we could stuck in a cycle of kill->restart->kill. This CL caps the number of auto resumptions. And reset the cap when user relaunches chrome. BUG=623242 Committed: https://crrev.com/f9c0e04cb04c53076b464486d84ea0f9bf764698 Cr-Commit-Position: refs/heads/master@{#402340}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 6 chunks +43 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
qinmin
PTAL
4 years, 6 months ago (2016-06-24 23:33:53 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2094033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java (right): https://codereview.chromium.org/2094033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java#newcode587 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:587: * @return a list of parsed DownloadSharedPreferenceEntry. update ...
4 years, 5 months ago (2016-06-27 17:13:08 UTC) #3
qinmin
https://codereview.chromium.org/2094033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java (right): https://codereview.chromium.org/2094033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java#newcode587 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:587: * @return a list of parsed DownloadSharedPreferenceEntry. On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 22:02:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094033002/20001
4 years, 5 months ago (2016-06-27 22:47:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 00:21:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:23:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9c0e04cb04c53076b464486d84ea0f9bf764698
Cr-Commit-Position: refs/heads/master@{#402340}

Powered by Google App Engine
This is Rietveld 408576698