Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 209393015: Add a minimal --undefok to SkCommandLineFlags. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
scroggo, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a minimal --undefok to SkCommandLineFlags. Similar in spirit to gflags' undefok, I'd like to be able to ignore specific unknown flags. This lets me run the same command line on, say, a branch that's got a new flag and on a clean branch tracking origin/master. This is handy for performance comparison, etc. It's not essential, and if you hate this I can find another way. As an example, I want to compare the runtime of SKP recording with my new code. I've added a flag --skr to bench_record to help this. So I want to compare origin/master: out/Release/bench_record my patch: out/Release/bench_record --skr This lets me run both as out/Release/bench_record --undefok skr --skr, which is handy for scripts and things. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13945

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M tools/flags/SkCommandLineFlags.cpp View 2 chunks +10 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 9 months ago (2014-03-25 19:59:48 UTC) #1
scroggo
On 2014/03/25 19:59:48, mtklein wrote: LGTM
6 years, 9 months ago (2014-03-25 20:04:23 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-25 20:05:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/209393015/1
6 years, 9 months ago (2014-03-25 20:05:23 UTC) #4
scroggo
https://codereview.chromium.org/209393015/diff/1/tools/flags/SkCommandLineFlags.cpp File tools/flags/SkCommandLineFlags.cpp (right): https://codereview.chromium.org/209393015/diff/1/tools/flags/SkCommandLineFlags.cpp#newcode11 tools/flags/SkCommandLineFlags.cpp:11: DEFINE_string(undefok, "", "Silently ignore unknown flags listed here instead ...
6 years, 9 months ago (2014-03-25 20:09:06 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 21:00:04 UTC) #6
Message was sent while issue was closed.
Change committed as 13945

Powered by Google App Engine
This is Rietveld 408576698