Add a minimal --undefok to SkCommandLineFlags.

tools/flags/SkCommandLineFlags.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCommandLineFlags.h"
 #include "SkTDArray.h"
 
+DEFINE_string(undefok, "", "Silently ignore unknown flags listed here instead of crashing.");

[scroggo, 2014/03/25 20:09:06]

Maybe specify that the use of this flag must follow undefok?

+
 bool SkFlagInfo::CreateStringFlag(const char* name, const char* shortName,
                                   SkCommandLineFlags::StringArray* pStrings,
                                   const char* defaultValue, const char* helpString) {
     SkFlagInfo* info = SkNEW_ARGS(SkFlagInfo, (name, shortName, kString_FlagType, helpString));
     info->fDefaultString.set(defaultValue);
 
     info->fStrings = pStrings;
     SetDefaultStrings(pStrings, defaultValue);
     return true;
 }
@@ skipping 257 matching lines @@
                             flag->setDouble(atof(argv[i]));
                             break;
                         default:
                             SkDEBUGFAIL("Invalid flag type");
                     }
                     break;
                 }
                 flag = flag->next();
             }
             if (!flagMatched) {
-                SkDebugf("Got unknown flag \"%s\". Exiting.\n", argv[i]);
-                exit(-1);
+                SkString stripped(argv[i]);
+                while (stripped.startsWith('-')) {
+                    stripped.remove(0, 1);
+                }
+                if (!FLAGS_undefok.contains(stripped.c_str())) {
+                    SkDebugf("Got unknown flag \"%s\". Exiting.\n", argv[i]);
+                    exit(-1);
+                }
             }
         }
     }
     // Since all of the flags have been set, release the memory used by each
     // flag. FLAGS_x can still be used after this.
     SkFlagInfo* flag = gHead;
     gHead = NULL;
     while (flag != NULL) {
         SkFlagInfo* next = flag->next();
         SkDELETE(flag);
@@ skipping 39 matching lines @@
 }
 
 }  // namespace
 
 bool SkCommandLineFlags::ShouldSkip(const SkTDArray<const char*>& strings, const char* name) {
     return ShouldSkipImpl(strings, name);
 }
 bool SkCommandLineFlags::ShouldSkip(const StringArray& strings, const char* name) {
     return ShouldSkipImpl(strings, name);
 }