Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6611)

Unified Diff: chrome/browser/ui/startup/bad_flags_prompt.cc

Issue 209393004: Only enable speech dispatcher on Linux with an explicit switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/bad_flags_prompt.cc
diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc b/chrome/browser/ui/startup/bad_flags_prompt.cc
index 5779c99d263862c1b8176a1569ce014bc5c90c3e..ac9d7791404ac09a6f1dd8ebecbb0d4d41981735 100644
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
@@ -65,6 +65,11 @@ void ShowBadFlagsPrompt(Browser* browser) {
// This flag gives extensions more powers.
extensions::switches::kExtensionsOnChromeURLs,
+
+ #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
msw 2014/03/24 17:11:00 nit: these should have no indentation.
dmazzoni 2014/03/24 22:08:42 Fixed. I was being consistent with another define
+ // Speech dispatcher is buggy, it can crash and it can make Chrome freeze.
msw 2014/03/24 17:11:00 nit: this should be a TODO with an associated bug
dmazzoni 2014/03/24 22:08:42 I added the bug, but no TODO for now since it's no
+ switches::kEnableSpeechDispatcher,
+ #endif
NULL
};

Powered by Google App Engine
This is Rietveld 408576698