Only enable speech dispatcher on Linux with an explicit switch.

chrome/browser/ui/startup/bad_flags_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/bad_flags_prompt.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 47 matching lines @@
     switches::kReduceSecurityForTesting,
     switches::kSyncAllowInsecureXmppConnection,
 
     // These flags change the URLs that handle PII.
     autofill::switches::kWalletSecureServiceUrl,
     switches::kGaiaUrl,
     translate::switches::kTranslateScriptURL,
 
     // This flag gives extensions more powers.
     extensions::switches::kExtensionsOnChromeURLs,
+
+  #if defined(OS_LINUX) && !defined(OS_CHROMEOS)

[msw, 2014/03/24 17:11:00]

nit: these should have no indentation.

[dmazzoni, 2014/03/24 22:08:42]

Fixed. I was being consistent with another define above, so I fixed it too.

+    // Speech dispatcher is buggy, it can crash and it can make Chrome freeze.

[msw, 2014/03/24 17:11:00]

nit: this should be a TODO with an associated bug number.

[dmazzoni, 2014/03/24 22:08:42]

I added the bug, but no TODO for now since it's not clear if we'll try to fix
the instability or just get rid of speech-dispatcher support or just leave this
switch for a while for the users who need it.

+    switches::kEnableSpeechDispatcher,
+  #endif
     NULL
   };
 
   for (const char** flag = kBadFlags; *flag; ++flag) {
     if (CommandLine::ForCurrentProcess()->HasSwitch(*flag)) {
       SimpleAlertInfoBarDelegate::Create(
           InfoBarService::FromWebContents(web_contents),
           InfoBarDelegate::kNoIconID,
           l10n_util::GetStringFUTF16(IDS_BAD_FLAGS_WARNING_MESSAGE,
                                      base::UTF8ToUTF16(
@@ skipping 29 matching lines @@
                                  user_data_dir.LossyDisplayName());
 
   if (cleanup_resource_bundle)
     ResourceBundle::CleanupSharedInstance();
 
   // More complex dialogs cannot be shown before the earliest calls here.
   ShowMessageBox(NULL, title, message, chrome::MESSAGE_BOX_TYPE_WARNING);
 }
 
 }  // namespace chrome