Only enable speech dispatcher on Linux with an explicit switch.

Only enable speech dispatcher on Linux with an explicit switch.

Now that the speechSynthesis api is part of the drive-by web, we don't
want just visiting a malicious site to be able to cause speech-dispatcher
to crash.

BUG=327295, 333003
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259109

[dmazzoni, 2014-03-22 14:10:16]

dtseng: see the bug for context; does this look okay and how could we publicize
this to users?
msw for chrome/browser/ui/...

[David Tseng, 2014-03-24 16:35:54]

lgtm

[msw, 2014-03-24 17:11:00]

LGTM with nits. I don't have access to issue 327295, but presume it's related
crashes.

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
File chrome/browser/ui/startup/bad_flags_prompt.cc (right):

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
chrome/browser/ui/startup/bad_flags_prompt.cc:69: #if defined(OS_LINUX) &&
!defined(OS_CHROMEOS)
nit: these should have no indentation.

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
chrome/browser/ui/startup/bad_flags_prompt.cc:70: // Speech dispatcher is buggy,
it can crash and it can make Chrome freeze.
nit: this should be a TODO with an associated bug number.

https://codereview.chromium.org/209393004/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/209393004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:1447: const char kEnableSpeechDispatcher[] =
"enable-speech-dispatcher";
nit: add a comment briefly explaining what enabling speech dispatcher does, and
why this flag is necessary.

[dmazzoni, 2014-03-24 22:08:42]

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
File chrome/browser/ui/startup/bad_flags_prompt.cc (right):

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
chrome/browser/ui/startup/bad_flags_prompt.cc:69: #if defined(OS_LINUX) &&
!defined(OS_CHROMEOS)
On 2014/03/24 17:11:00, msw wrote:
> nit: these should have no indentation.

Fixed. I was being consistent with another define above, so I fixed it too.

https://codereview.chromium.org/209393004/diff/1/chrome/browser/ui/startup/ba...
chrome/browser/ui/startup/bad_flags_prompt.cc:70: // Speech dispatcher is buggy,
it can crash and it can make Chrome freeze.
On 2014/03/24 17:11:00, msw wrote:
> nit: this should be a TODO with an associated bug number.

I added the bug, but no TODO for now since it's not clear if we'll try to fix
the instability or just get rid of speech-dispatcher support or just leave this
switch for a while for the users who need it.

https://codereview.chromium.org/209393004/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/209393004/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:1447: const char kEnableSpeechDispatcher[] =
"enable-speech-dispatcher";
On 2014/03/24 17:11:00, msw wrote:
> nit: add a comment briefly explaining what enabling speech dispatcher does,
and
> why this flag is necessary.

Done.

[dmazzoni, 2014-03-24 22:08:46]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/209393004/1

[dmazzoni, 2014-03-24 22:16:08]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:23:49]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-03-24 22:23:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/209393004/20001

[commit-bot: I haz the power, 2014-03-25 02:35:54]

Change committed as 259109