Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Issue 2093913002: DevTools: When no manifest detected, provide user with link to docs. (Closed)

Created:
4 years, 6 months ago by paulirish
Modified:
3 years, 10 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: When no manifest detected, provide user with link to docs. BUG= Review-Url: https://codereview.chromium.org/2093913002 Cr-Commit-Position: refs/heads/master@{#450250} Committed: https://chromium.googlesource.com/chromium/src/+/4c6747c1032af89b54e32d268439add818cbe37b

Patch Set 1 #

Patch Set 2 : closure fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 1 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/reportView.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
paulirish
ptal
4 years, 6 months ago (2016-06-24 11:09:09 UTC) #2
Addy Osmani
On 2016/06/24 11:09:09, paulirish wrote: > ptal Visual and behaviour changes here lgtm. Some follow-ups ...
4 years, 6 months ago (2016-06-24 11:15:14 UTC) #3
paulirish
4 years, 6 months ago (2016-06-24 17:02:50 UTC) #5
kayce (google)
On 2016/06/24 11:09:09, paulirish wrote: > ptal Wouldn't this be a better link? https://developers.google.com/web/fundamentals/engage-and-retain/app-install-banners?utm_source=devtools I ...
4 years, 5 months ago (2016-06-29 00:57:41 UTC) #6
pfeldman
bug / screenshot plz?
4 years, 5 months ago (2016-07-07 01:12:59 UTC) #7
pfeldman
lgtm
3 years, 10 months ago (2017-01-30 21:38:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093913002/20001
3 years, 10 months ago (2017-02-14 02:21:00 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 04:41:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c6747c1032af89b54e32d268439...

Powered by Google App Engine
This is Rietveld 408576698