Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 209383011: Remove SkiaFontWin as it is no longer used (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove SkiaFontWin as it is no longer used Remove the SkiaFontWin.cpp and SkiaFontWin.h files and all references to them as the paintSkiaText method provided by SkiaFontWin.h is no longer used now that the Uniscribe code path has been removed. R=schenney@chromium.org BUG=313423 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -203 lines) Patch
M Source/platform/blink_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/platform/fonts/mac/FontMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/platform/fonts/win/SkiaFontWin.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/platform/fonts/win/SkiaFontWin.cpp View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
eae
6 years, 9 months ago (2014-03-24 18:37:25 UTC) #1
Stephen Chennney
lgtm
6 years, 9 months ago (2014-03-24 18:59:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 18:59:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:01:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 19:01:49 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 19:05:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 19:05:25 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:06:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 19:06:38 UTC) #9
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 19:08:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 19:08:06 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:12:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 19:12:39 UTC) #13
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 19:26:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 19:26:58 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:33:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 19:33:11 UTC) #17
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 19:49:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 19:49:30 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 20:05:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 20:05:28 UTC) #21
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 20:05:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 20:05:47 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 20:10:52 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 20:10:54 UTC) #25
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 21:30:36 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 21:30:41 UTC) #27
eae
On 2014/03/24 21:30:41, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-24 21:30:51 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 21:48:43 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 21:48:43 UTC) #30
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 21:51:15 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209383011/1
6 years, 9 months ago (2014-03-24 21:51:23 UTC) #32
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 23:51:33 UTC) #33
Message was sent while issue was closed. 
Change committed as 169888

Powered by Google App Engine
This is Rietveld 408576698