Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2093823003: [wasm] Deleting unused parameter from function "consume_u32v" (Closed)

Created:
4 years, 6 months ago by ritesht
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Mircea Trofin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Deleting unused parameter from function "consume_u32v" Merge branch 'master' of https://chromium.googlesource.com/v7/v8 into unused_variables Removed unused variables "length" from the signature "consume_u32v". The variable length (passed in as a parameter) is not read from the function, rather it set based on the pc_ offset. However, the value set is also not used in the main line of control flow during decoding. This seems to be some dead code. BUG= Committed: https://crrev.com/cbbcef803b16e705a46b248161fcd7bbdc39f688 Cr-Commit-Position: refs/heads/master@{#37233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -67 lines) Patch
M src/wasm/ast-decoder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/wasm/decoder.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/wasm/module-decoder.cc View 24 chunks +28 lines, -60 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ritesht
4 years, 6 months ago (2016-06-23 23:31:21 UTC) #3
Mircea Trofin
lgtm Lgtm
4 years, 6 months ago (2016-06-23 23:44:55 UTC) #5
bradnelson
LGTM, but I've removed the BUG reference to jiting, as this is unrelated cleanup (things ...
4 years, 6 months ago (2016-06-24 00:21:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093823003/1
4 years, 6 months ago (2016-06-24 00:21:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 00:24:47 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 00:27:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbbcef803b16e705a46b248161fcd7bbdc39f688
Cr-Commit-Position: refs/heads/master@{#37233}

Powered by Google App Engine
This is Rietveld 408576698