Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: src/wasm/decoder.h

Issue 2093823003: [wasm] Deleting unused parameter from function "consume_u32v" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | src/wasm/module-decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/decoder.h
diff --git a/src/wasm/decoder.h b/src/wasm/decoder.h
index 9136fa511d4e3bb562e50612dc944c444d74a3ca..cde352dd19cbfd356223bf76e23d545db02e8873 100644
--- a/src/wasm/decoder.h
+++ b/src/wasm/decoder.h
@@ -204,10 +204,9 @@ class Decoder {
}
// Reads a LEB128 variable-length 32-bit integer and advances {pc_}.
- uint32_t consume_u32v(int* length, const char* name = nullptr) {
+ uint32_t consume_u32v(const char* name = nullptr) {
TRACE(" +%d %-20s: ", static_cast<int>(pc_ - start_),
name ? name : "varint");
-
if (checkAvailable(1)) {
const byte* pos = pc_;
const byte* end = pc_ + 5;
@@ -224,10 +223,10 @@ class Decoder {
shift += 7;
}
- *length = static_cast<int>(pc_ - pos);
+ int length = static_cast<int>(pc_ - pos);
if (pc_ == end && (b & 0x80)) {
error(pc_ - 1, "varint too large");
- } else if (*length == 0) {
+ } else if (length == 0) {
error(pc_, "varint of length 0");
} else {
TRACE("= %u\n", result);
« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | src/wasm/module-decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698