Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2093763003: Change SkColor4f to RGBA channel order (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reorder Pin arguments, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -34 lines) Patch
M gm/color4f.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M include/core/SkColor.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M src/core/SkColor.cpp View 1 3 chunks +14 lines, -10 lines 0 comments Download
M src/core/SkColorShader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPixmap.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/Float16Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093763003/20001
4 years, 6 months ago (2016-06-24 12:56:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 13:14:37 UTC) #5
Brian Osman
4 years, 6 months ago (2016-06-24 13:20:19 UTC) #7
reed1
lgtm
4 years, 6 months ago (2016-06-24 13:27:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093763003/20001
4 years, 6 months ago (2016-06-24 13:30:37 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 13:31:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e074d1fa6ace83dd77971b971c07166bedeb28ef

Powered by Google App Engine
This is Rietveld 408576698