|
|
Created:
4 years, 6 months ago by erikchen Modified:
4 years, 6 months ago CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@temp96_new_deschedule Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a call to DescheduleUntilFinishedCHROMIUM to WebGL.
It was recently removed in https://codereview.chromium.org/2062813003/ because I
thought that the new implementation to
ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL
context's work to finish. That is only the case on some macOS/gpu
configurations.
BUG=611805
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/eb44a4aee7dc6e03ba4670509b08d038fbad2d48
Cr-Commit-Position: refs/heads/master@{#401688}
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Fix a DCHECK. #
Depends on Patchset: Messages
Total messages: 35 (16 generated)
erikchen@chromium.org changed reviewers: + kbr@chromium.org
kbr: Please review.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
LGTM Per earlier discussions is it likely this will cause any performance regressions, e.g. on the Oort Online benchmark? Or does the implementation now allow a couple of frames to be buffered?
On 2016/06/23 00:29:50, Ken Russell wrote: > LGTM > > Per earlier discussions is it likely this will cause any performance > regressions, e.g. on the Oort Online benchmark? Or does the implementation now > allow a couple of frames to be buffered? This should not cause any performance regressions, and should keep the 10% gain from switching to Image CHROMIUM. This CL is dependent on https://codereview.chromium.org/2096503002#ps1, which changes the behavior of DescheduleUntilFinishedCHROMIUM to allow a buffer frame.
On 2016/06/23 00:33:05, erikchen wrote: > On 2016/06/23 00:29:50, Ken Russell wrote: > > LGTM > > > > Per earlier discussions is it likely this will cause any performance > > regressions, e.g. on the Oort Online benchmark? Or does the implementation now > > allow a couple of frames to be buffered? > > This should not cause any performance regressions, and should keep the 10% gain > from switching to Image CHROMIUM. This CL is dependent on > https://codereview.chromium.org/2096503002#ps1, which changes the behavior of > DescheduleUntilFinishedCHROMIUM to allow a buffer frame. Sounds great.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. It was recently removed in https://codereview.chromium.org/2062813003/ because I thought that the new implementation to ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL context's work to finish. That is only the case on some macOS/gpu configurations. BUG=611805 ========== to ========== Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. It was recently removed in https://codereview.chromium.org/2062813003/ because I thought that the new implementation to ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL context's work to finish. That is only the case on some macOS/gpu configurations. BUG=611805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/40001
erikchen@chromium.org changed reviewers: + piman@chromium.org
piman: Please review gpu/ipc/service/gpu_command_buffer_stub.cc.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2093533002/#ps40001 (title: "Fix a DCHECK.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. It was recently removed in https://codereview.chromium.org/2062813003/ because I thought that the new implementation to ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL context's work to finish. That is only the case on some macOS/gpu configurations. BUG=611805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. It was recently removed in https://codereview.chromium.org/2062813003/ because I thought that the new implementation to ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL context's work to finish. That is only the case on some macOS/gpu configurations. BUG=611805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/eb44a4aee7dc6e03ba4670509b08d038fbad2d48 Cr-Commit-Position: refs/heads/master@{#401688} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/eb44a4aee7dc6e03ba4670509b08d038fbad2d48 Cr-Commit-Position: refs/heads/master@{#401688} |