Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2093533002: Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp96_new_deschedule
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a call to DescheduleUntilFinishedCHROMIUM to WebGL. It was recently removed in https://codereview.chromium.org/2062813003/ because I thought that the new implementation to ImageTransportSurfaceOverlayMac::ClientWait correctly waited for the WebGL context's work to finish. That is only the case on some macOS/gpu configurations. BUG=611805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/eb44a4aee7dc6e03ba4670509b08d038fbad2d48 Cr-Commit-Position: refs/heads/master@{#401688}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix a DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 35 (16 generated)
erikchen
kbr: Please review.
4 years, 6 months ago (2016-06-23 00:24:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
4 years, 6 months ago (2016-06-23 00:25:02 UTC) #4
Ken Russell (switch to Gerrit)
LGTM Per earlier discussions is it likely this will cause any performance regressions, e.g. on ...
4 years, 6 months ago (2016-06-23 00:29:50 UTC) #5
erikchen
On 2016/06/23 00:29:50, Ken Russell wrote: > LGTM > > Per earlier discussions is it ...
4 years, 6 months ago (2016-06-23 00:33:05 UTC) #6
Ken Russell (switch to Gerrit)
On 2016/06/23 00:33:05, erikchen wrote: > On 2016/06/23 00:29:50, Ken Russell wrote: > > LGTM ...
4 years, 6 months ago (2016-06-23 00:35:43 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/248803)
4 years, 6 months ago (2016-06-23 02:10:23 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
4 years, 6 months ago (2016-06-23 04:08:18 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/248874)
4 years, 6 months ago (2016-06-23 04:12:17 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/1
4 years, 6 months ago (2016-06-23 06:23:28 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/248951)
4 years, 6 months ago (2016-06-23 08:20:30 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/20001
4 years, 6 months ago (2016-06-23 17:26:39 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/249190)
4 years, 6 months ago (2016-06-23 18:14:15 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/40001
4 years, 6 months ago (2016-06-23 18:18:52 UTC) #24
erikchen
piman: Please review gpu/ipc/service/gpu_command_buffer_stub.cc.
4 years, 6 months ago (2016-06-23 18:58:54 UTC) #26
piman
lgtm
4 years, 6 months ago (2016-06-23 19:30:57 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 19:36:31 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093533002/40001
4 years, 6 months ago (2016-06-23 19:39:18 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 19:45:30 UTC) #33
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:46:51 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb44a4aee7dc6e03ba4670509b08d038fbad2d48
Cr-Commit-Position: refs/heads/master@{#401688}

Powered by Google App Engine
This is Rietveld 408576698