Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2096503002: Implement new behavior for DescheduleUntilFinishedCHROMIUM. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp95
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement new behavior for DescheduleUntilFinishedCHROMIUM. Previously, the command immediately descheduled the command executor until all previously issued work had completed. This prevents pipelining of CPU-bound decoding and GPU-bound drawing. The new behavior deschedules the command executor until all work issued prior to the previous call to DescheduleUntilFinishedCHROMIUM has completed. BUG=611805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4acb5991cddf0dd2a0efb392c9a5691dfd5af2d6 Cr-Commit-Position: refs/heads/master@{#401544}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_deschedule.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 4 chunks +20 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
erikchen
piman: Please review.
4 years, 6 months ago (2016-06-23 00:20:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096503002/1
4 years, 6 months ago (2016-06-23 00:20:53 UTC) #5
piman
lgtm
4 years, 6 months ago (2016-06-23 01:05:37 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096503002/1
4 years, 6 months ago (2016-06-23 01:13:14 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 01:50:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096503002/1
4 years, 6 months ago (2016-06-23 02:44:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/205618)
4 years, 6 months ago (2016-06-23 02:50:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096503002/20001
4 years, 6 months ago (2016-06-23 03:26:14 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 05:39:09 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 05:45:26 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4acb5991cddf0dd2a0efb392c9a5691dfd5af2d6
Cr-Commit-Position: refs/heads/master@{#401544}

Powered by Google App Engine
This is Rietveld 408576698