Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2093493002: Change the visibility of NQE public functions (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 5 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the visibility of NQE public functions These functions expose raw metrics such as estimated HTTP RTT, transport RTT, bandwidth. They can now all be "protected" since data reduction proxy has switched to GetEffectiveConnectionType(). BUG=615551 Committed: https://crrev.com/b44b0d04552b1fa23c653196a8d33bf30f477e07 Cr-Commit-Position: refs/heads/master@{#402254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M net/nqe/network_quality_estimator.h View 3 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tbansal1
bengr: ptal. Thanks.
4 years, 6 months ago (2016-06-22 18:41:54 UTC) #4
bengr
lgtm
4 years, 5 months ago (2016-06-27 01:21:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093493002/1
4 years, 5 months ago (2016-06-27 17:05:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 19:30:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 19:31:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b44b0d04552b1fa23c653196a8d33bf30f477e07
Cr-Commit-Position: refs/heads/master@{#402254}

Powered by Google App Engine
This is Rietveld 408576698