Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4889)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2093493002: Change the visibility of NQE public functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 576484299f603e75492e43b431c772b5564134ca..695fbe142f4fff4772e72c1fe12d30d81ce8cfa6 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -185,24 +185,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
void RemoveEffectiveConnectionTypeObserver(
EffectiveConnectionTypeObserver* observer);
- // Returns true if the RTT is available and sets |rtt| to the RTT estimated at
- // the HTTP layer. Virtualized for testing. |rtt| should not be null. The RTT
- // at the HTTP layer measures the time from when the request was sent (this
- // happens after the connection is established) to the time when the response
- // headers were received.
- virtual bool GetHttpRTTEstimate(base::TimeDelta* rtt) const
- WARN_UNUSED_RESULT;
-
- // Returns true if the RTT is available and sets |rtt| to the RTT estimated at
- // the transport layer. |rtt| should not be null. Virtualized for testing.
- virtual bool GetTransportRTTEstimate(base::TimeDelta* rtt) const
- WARN_UNUSED_RESULT;
-
- // Returns true if downlink throughput is available and sets |kbps| to
- // estimated downlink throughput (in kilobits per second).
- // Virtualized for testing. |kbps| should not be null.
- virtual bool GetDownlinkThroughputKbpsEstimate(int32_t* kbps) const;
-
// Notifies NetworkQualityEstimator that the response header of |request| has
// been received.
void NotifyHeadersReceived(const URLRequest& request);
@@ -218,31 +200,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// Notifies NetworkQualityEstimator that |request| will be destroyed.
void NotifyURLRequestDestroyed(const URLRequest& request);
- // Returns true if median RTT at the HTTP layer is available and sets |rtt|
- // to the median of RTT observations since |start_time|.
- // Virtualized for testing. |rtt| should not be null. The RTT at the HTTP
- // layer measures the time from when the request was sent (this happens after
- // the connection is established) to the time when the response headers were
- // received.
- virtual bool GetRecentHttpRTTMedian(const base::TimeTicks& start_time,
- base::TimeDelta* rtt) const
- WARN_UNUSED_RESULT;
-
- // Returns true if the median RTT at the transport layer is available and sets
- // |rtt| to the median of transport layer RTT observations since
- // |start_time|. |rtt| should not be null. Virtualized for testing.
- virtual bool GetRecentTransportRTTMedian(const base::TimeTicks& start_time,
- base::TimeDelta* rtt) const
- WARN_UNUSED_RESULT;
-
- // Returns true if median downstream throughput is available and sets |kbps|
- // to the median of downstream throughput (in kilobits per second)
- // observations since |start_time|. Virtualized for testing. |kbps|
- // should not be null. Virtualized for testing.
- virtual bool GetRecentMedianDownlinkThroughputKbps(
- const base::TimeTicks& start_time,
- int32_t* kbps) const WARN_UNUSED_RESULT;
-
// Adds |rtt_observer| to the list of round trip time observers. Must be
// called on the IO thread.
void AddRTTObserver(RTTObserver* rtt_observer);
@@ -319,6 +276,49 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
int32_t downstream_throughput_kbps,
int32_t upstream_throughput_kbps) override;
+ // Returns true if the RTT is available and sets |rtt| to the RTT estimated at
+ // the HTTP layer. Virtualized for testing. |rtt| should not be null. The RTT
+ // at the HTTP layer measures the time from when the request was sent (this
+ // happens after the connection is established) to the time when the response
+ // headers were received.
+ virtual bool GetHttpRTTEstimate(base::TimeDelta* rtt) const
+ WARN_UNUSED_RESULT;
+
+ // Returns true if the RTT is available and sets |rtt| to the RTT estimated at
+ // the transport layer. |rtt| should not be null. Virtualized for testing.
+ virtual bool GetTransportRTTEstimate(base::TimeDelta* rtt) const
+ WARN_UNUSED_RESULT;
+
+ // Returns true if downlink throughput is available and sets |kbps| to
+ // estimated downlink throughput (in kilobits per second).
+ // Virtualized for testing. |kbps| should not be null.
+ virtual bool GetDownlinkThroughputKbpsEstimate(int32_t* kbps) const;
+
+ // Returns true if median RTT at the HTTP layer is available and sets |rtt|
+ // to the median of RTT observations since |start_time|.
+ // Virtualized for testing. |rtt| should not be null. The RTT at the HTTP
+ // layer measures the time from when the request was sent (this happens after
+ // the connection is established) to the time when the response headers were
+ // received.
+ virtual bool GetRecentHttpRTTMedian(const base::TimeTicks& start_time,
+ base::TimeDelta* rtt) const
+ WARN_UNUSED_RESULT;
+
+ // Returns true if the median RTT at the transport layer is available and sets
+ // |rtt| to the median of transport layer RTT observations since
+ // |start_time|. |rtt| should not be null. Virtualized for testing.
+ virtual bool GetRecentTransportRTTMedian(const base::TimeTicks& start_time,
+ base::TimeDelta* rtt) const
+ WARN_UNUSED_RESULT;
+
+ // Returns true if median downstream throughput is available and sets |kbps|
+ // to the median of downstream throughput (in kilobits per second)
+ // observations since |start_time|. Virtualized for testing. |kbps|
+ // should not be null. Virtualized for testing.
+ virtual bool GetRecentMedianDownlinkThroughputKbps(
+ const base::TimeTicks& start_time,
+ int32_t* kbps) const WARN_UNUSED_RESULT;
+
// Returns the list of intervals at which the accuracy of network quality
// prediction should be recorded. Virtualized for testing.
virtual const std::vector<base::TimeDelta>& GetAccuracyRecordingIntervals()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698