Clean up some supposedly failing tests

pkg/analyzer/test/generated/all_the_rest_test.dart

Index: pkg/analyzer/test/generated/all_the_rest_test.dart
diff --git a/pkg/analyzer/test/generated/all_the_rest_test.dart b/pkg/analyzer/test/generated/all_the_rest_test.dart
index ba1ba0082e83a854e5eb3d0ca2a3f25647ddd044..f6ae442fb8c3e5fdd11e3071a5b0958910f7bcbf 100644
--- a/pkg/analyzer/test/generated/all_the_rest_test.dart
+++ b/pkg/analyzer/test/generated/all_the_rest_test.dart
@@ -2565,14 +2565,14 @@ class C {
 
 @reflectiveTest
 class ElementLocatorTest extends ResolverTestCase {
-  void fail_locate_ExportDirective() {
+  void test_locate_ExportDirective() {
     AstNode id = _findNodeIn("export", "export 'dart:core';");
     Element element = ElementLocator.locate(id);
     EngineTestCase.assertInstanceOf(
-        (obj) => obj is ImportElement, ImportElement, element);
+        (obj) => obj is ExportElement, ExportElement, element);
   }
 
-  void fail_locate_Identifier_libraryDirective() {
+  void test_locate_Identifier_libraryDirective() {
     AstNode id = _findNodeIn("foo", "library foo.bar;");
     Element element = ElementLocator.locate(id);
     EngineTestCase.assertInstanceOf(
@@ -3267,18 +3267,6 @@ class ErrorSeverityTest extends EngineTestCase {
  */
 @reflectiveTest
 class ExitDetectorTest extends ParserTestCase {
-  void fail_doStatement_continue_with_label() {
-    _assertFalse("{ x: do { continue x; } while(true); }");
-  }
-
-  void fail_whileStatement_continue_with_label() {
-    _assertFalse("{ x: while (true) { continue x; } }");
-  }
-
-  void fail_whileStatement_doStatement_scopeRequired() {
-    _assertTrue("{ while (true) { x: do { continue x; } while(true); }");

[srawlins, 2016/06/22 20:57:43]

This was only failing because it didn't have enough "}" at the end. Syntax
error.

-  }
-
   void test_asExpression() {
     _assertFalse("a as Object;");
   }
@@ -3495,6 +3483,11 @@ class ExitDetectorTest extends ParserTestCase {
     _assertTrue("{ do { continue; } while (true); }");
   }
 
+  void test_doStatement_true_continueWithLabel() {
+    _assertTrue("{ x: do { continue x; } while (true); }");

[srawlins, 2016/06/22 20:57:43]

I changed these to _assertTrue because... this does "exit" (infinite loop in
this case), right?

[Brian Wilkerson, 2016/06/22 21:46:24]

I don't understand. I would say that an infinite loop doesn't exit, which is
consistent with methods like test_doStatement_true_break. But I don't understand
why test_doStatement_true_continue uses _assertTrue.

It looks to me like these should remain _assertFalse, and a few other tests
should also be _assertFalse.

[srawlins, 2016/06/22 23:12:27]

Here's the description of ExitDetector:

"Instances of the class `ExitDetector` determine whether the visited AST node is
guaranteed to terminate by executing a `return` statement, `throw` expression,
`rethrow` expression, or simple infinite loop such as `while(true)`." [1]

So infinite loops "exit" under this definition. "test_doStatement_true_break"
does _not_ exit because it merely breaks, and does not exit, where as
"test_doStatement_true_continue" _does_ exit, because it infinite loops.

[1]
https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/generated/r...

+  }
+
+
   void test_doStatement_true_if_return() {
     _assertTrue("{ do { if (true) {return null;} } while (true); }");
   }
@@ -3888,6 +3881,14 @@ on String catch (e, s) { return 1; }''');
     _assertTrue("{ while (true) { continue; } }");
   }
 
+  void test_whileStatement_true_continueWithLabel() {
+    _assertTrue("{ x: while (true) { continue x; } }");
+  }
+
+  void test_whileStatement_true_doStatement_scopeRequired() {
+    _assertTrue("{ while (true) { x: do { continue x; } while (true); } }");
+  }
+
   void test_whileStatement_true_if_return() {
     _assertTrue("{ while (true) { if (true) {return null;} } }");
   }