Clean up some supposedly failing tests

pkg/analyzer/test/generated/all_the_rest_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.all_the_rest_test;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 2547 matching lines @@
         null,
         null,
         AstFactory.identifier3("main"),
         AstFactory.formalParameterList([formalParameter]),
         body);
   }
 }
 
 @reflectiveTest
 class ElementLocatorTest extends ResolverTestCase {
-  void fail_locate_ExportDirective() {
+  void test_locate_ExportDirective() {
     AstNode id = _findNodeIn("export", "export 'dart:core';");
     Element element = ElementLocator.locate(id);
     EngineTestCase.assertInstanceOf(
-        (obj) => obj is ImportElement, ImportElement, element);
+        (obj) => obj is ExportElement, ExportElement, element);
   }
 
-  void fail_locate_Identifier_libraryDirective() {
+  void test_locate_Identifier_libraryDirective() {
     AstNode id = _findNodeIn("foo", "library foo.bar;");
     Element element = ElementLocator.locate(id);
     EngineTestCase.assertInstanceOf(
         (obj) => obj is LibraryElement, LibraryElement, element);
   }
 
   void fail_locate_Identifier_partOfDirective() {
     // Can't resolve the library element without the library declaration.
     //    AstNode id = findNodeIn("foo", "part of foo.bar;");
     //    Element element = ElementLocator.locate(id);
@@ skipping 674 matching lines @@
   }
 }
 
 /**
  * Tests for the [ExitDetector] that do not require that the AST be resolved.
  *
  * See [ExitDetectorTest2] for tests that require the AST to be resolved.
  */
 @reflectiveTest
 class ExitDetectorTest extends ParserTestCase {
-  void fail_doStatement_continue_with_label() {
-    _assertFalse("{ x: do { continue x; } while(true); }");
-  }
-
-  void fail_whileStatement_continue_with_label() {
-    _assertFalse("{ x: while (true) { continue x; } }");
-  }
-
-  void fail_whileStatement_doStatement_scopeRequired() {
-    _assertTrue("{ while (true) { x: do { continue x; } while(true); }");

[srawlins, 2016/06/22 20:57:43]

This was only failing because it didn't have enough "}" at the end. Syntax
error.

-  }
-
   void test_asExpression() {
     _assertFalse("a as Object;");
   }
 
   void test_asExpression_throw() {
     _assertTrue("throw '' as Object;");
   }
 
   void test_assertStatement() {
     _assertFalse("assert(a);");
@@ skipping 196 matching lines @@
   }
 
   void test_doStatement_true_break() {
     _assertFalse("{ do { break; } while (true); }");
   }
 
   void test_doStatement_true_continue() {
     _assertTrue("{ do { continue; } while (true); }");
   }
 
+  void test_doStatement_true_continueWithLabel() {
+    _assertTrue("{ x: do { continue x; } while (true); }");

[srawlins, 2016/06/22 20:57:43]

I changed these to _assertTrue because... this does "exit" (infinite loop in
this case), right?

[Brian Wilkerson, 2016/06/22 21:46:24]

I don't understand. I would say that an infinite loop doesn't exit, which is
consistent with methods like test_doStatement_true_break. But I don't understand
why test_doStatement_true_continue uses _assertTrue.

It looks to me like these should remain _assertFalse, and a few other tests
should also be _assertFalse.

[srawlins, 2016/06/22 23:12:27]

Here's the description of ExitDetector:

"Instances of the class `ExitDetector` determine whether the visited AST node is
guaranteed to terminate by executing a `return` statement, `throw` expression,
`rethrow` expression, or simple infinite loop such as `while(true)`." [1]

So infinite loops "exit" under this definition. "test_doStatement_true_break"
does _not_ exit because it merely breaks, and does not exit, where as
"test_doStatement_true_continue" _does_ exit, because it infinite loops.

[1]
https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/generated/r...

+  }
+
+
   void test_doStatement_true_if_return() {
     _assertTrue("{ do { if (true) {return null;} } while (true); }");
   }
 
   void test_doStatement_true_noBreak() {
     _assertTrue("{ do {} while (true); }");
   }
 
   void test_doStatement_true_return() {
     _assertTrue("{ do { return null; } while (true);  }");
@@ skipping 373 matching lines @@
   }
 
   void test_whileStatement_true_break() {
     _assertFalse("{ while (true) { break; } }");
   }
 
   void test_whileStatement_true_continue() {
     _assertTrue("{ while (true) { continue; } }");
   }
 
+  void test_whileStatement_true_continueWithLabel() {
+    _assertTrue("{ x: while (true) { continue x; } }");
+  }
+
+  void test_whileStatement_true_doStatement_scopeRequired() {
+    _assertTrue("{ while (true) { x: do { continue x; } while (true); } }");
+  }
+
   void test_whileStatement_true_if_return() {
     _assertTrue("{ while (true) { if (true) {return null;} } }");
   }
 
   void test_whileStatement_true_noBreak() {
     _assertTrue("{ while (true) {} }");
   }
 
   void test_whileStatement_true_return() {
     _assertTrue("{ while (true) { return null; } }");
@@ skipping 589 matching lines @@
     expect(UriKind.fromEncoding(0x70), same(UriKind.PACKAGE_URI));
     expect(UriKind.fromEncoding(0x58), same(null));
   }
 
   void test_getEncoding() {
     expect(UriKind.DART_URI.encoding, 0x64);
     expect(UriKind.FILE_URI.encoding, 0x66);
     expect(UriKind.PACKAGE_URI.encoding, 0x70);
   }
 }