Clean up some supposedly failing tests

Clean up some supposedly failing tests

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c30e2f20eda465bef38dfaa9829edecf6741fcd

[srawlins, 2016-06-22 20:56:04]

srawlins@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[srawlins, 2016-06-22 20:56:04]

Found some fail_ tests that were easy to fix.

[srawlins, 2016-06-22 20:57:44]

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (left):

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3279: _assertTrue("{ while
(true) { x: do { continue x; } while(true); }");
This was only failing because it didn't have enough "}" at the end. Syntax
error.

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3487: _assertTrue("{ x: do {
continue x; } while (true); }");
I changed these to _assertTrue because... this does "exit" (infinite loop in
this case), right?

[Brian Wilkerson, 2016-06-22 21:46:25]

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3487: _assertTrue("{ x: do {
continue x; } while (true); }");
> I changed these to _assertTrue because... this does "exit" (infinite loop in
> this case), right?

I don't understand. I would say that an infinite loop doesn't exit, which is
consistent with methods like test_doStatement_true_break. But I don't understand
why test_doStatement_true_continue uses _assertTrue.

It looks to me like these should remain _assertFalse, and a few other tests
should also be _assertFalse.

[srawlins, 2016-06-22 23:12:27]

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2093473002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:3487: _assertTrue("{ x: do {
continue x; } while (true); }");
On 2016/06/22 21:46:24, Brian Wilkerson wrote:
> > I changed these to _assertTrue because... this does "exit" (infinite loop in
> > this case), right?
> 
> I don't understand. I would say that an infinite loop doesn't exit, which is
> consistent with methods like test_doStatement_true_break. But I don't
understand
> why test_doStatement_true_continue uses _assertTrue.
> 
> It looks to me like these should remain _assertFalse, and a few other tests
> should also be _assertFalse.

Here's the description of ExitDetector:

"Instances of the class `ExitDetector` determine whether the visited AST node is
guaranteed to terminate by executing a `return` statement, `throw` expression,
`rethrow` expression, or simple infinite loop such as `while(true)`." [1]

So infinite loops "exit" under this definition. "test_doStatement_true_break"
does _not_ exit because it merely breaks, and does not exit, where as
"test_doStatement_true_continue" _does_ exit, because it infinite loops.

[1]
https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/generated/r...

[Brian Wilkerson, 2016-06-22 23:18:12]

lgtm

[srawlins, 2016-06-30 19:44:41]

Description was changed from

==========
Clean up some supposedly failing tests

BUG=
==========

to

==========
Clean up some supposedly failing tests

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1c30e2f20eda465bef38dfaa9829edecf6741fcd
==========

[srawlins, 2016-06-30 19:44:43]

Committed patchset #1 (id:1) manually as
1c30e2f20eda465bef38dfaa9829edecf6741fcd (presubmit successful).