Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: chrome/android/java/res/layout/confirm_important_sites_list_row.xml

Issue 2093373004: [ImportantStorage] Clear button string update and lint fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/manage_space_activity.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <LinearLayout 6 <LinearLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 android:layout_width="match_parent" 8 android:layout_width="match_parent"
9 android:layout_height="wrap_content" 9 android:layout_height="wrap_content"
10 android:orientation="horizontal" 10 android:orientation="horizontal"
11 android:minHeight="?attr/listPreferredItemHeightSmall" 11 android:minHeight="?attr/listPreferredItemHeightSmall"
12 android:paddingStart="19dp" 12 android:paddingStart="19dp"
13 android:paddingEnd="19dp"> 13 android:paddingEnd="19dp">
14 14
15 <CheckBox 15 <CheckBox
16 android:id="@+id/icon_row_checkbox" 16 android:id="@+id/icon_row_checkbox"
17 android:clickable="false" 17 android:clickable="false"
18 android:focusable="false" 18 android:focusable="false"
19 android:focusableInTouchMode="false" 19 android:focusableInTouchMode="false"
20 android:layout_width="0dp" 20 android:layout_width="0dp"
21 android:layout_weight="1" 21 android:layout_weight="1"
22 android:layout_height="match_parent" 22 android:layout_height="match_parent"
23 android:gravity="center_vertical" 23 android:gravity="center_vertical"
24 android:ellipsize="end" 24 android:ellipsize="end"
25 android:textSize="14sp" 25 android:textSize="14sp"
26 android:padding="2dp"/> 26 android:padding="2dp"/>
27 <ImageView 27 <ImageView
Theresa 2016/06/27 20:11:17 Can the image view gain focus when TalkBack is on?
dmurph 2016/06/27 21:28:44 Fixed by disabling accessibility.
28 android:id="@+id/icon_row_image" 28 android:id="@+id/icon_row_image"
29 android:contentDescription="@null"
29 android:layout_width="wrap_content" 30 android:layout_width="wrap_content"
30 android:layout_height="match_parent" 31 android:layout_height="match_parent"
31 android:gravity="center_vertical" 32 android:gravity="center_vertical"
32 android:scaleType="center" 33 android:scaleType="center"
33 android:padding="2dp" /> 34 android:padding="2dp" />
34 </LinearLayout> 35 </LinearLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout/manage_space_activity.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698