Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 209333005: Support invalidation sets for :host pseudo. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Support invalidation sets for :host pseudo. Traverse the selectorList() for :host pseudo, extract features, and create class invalidation sets like we do for features and classes on the top level. R=esprehn,ojan BUG=335247, 339729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169927

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -5 lines) Patch
A LayoutTests/fast/css/invalidation/targeted-class-host-pseudo.html View 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 4 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
rune
A rebased solution with review issues from [1] addressed. [1] https://codereview.chromium.org/208013002/
6 years, 9 months ago (2014-03-24 11:26:33 UTC) #1
rune
https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.h File Source/core/css/RuleFeature.h (right): https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.h#newcode148 Source/core/css/RuleFeature.h:148: void addFeaturesToInvalidationSets(const CSSSelector&, const Vector<AtomicString>& classes, AtomicString id, AtomicString ...
6 years, 9 months ago (2014-03-24 12:16:45 UTC) #2
esprehn
You didn't need to close and open a new issue. :)
6 years, 9 months ago (2014-03-24 15:59:51 UTC) #3
esprehn
lgtm, fix nits before landing. https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.cpp#newcode189 Source/core/css/RuleFeature.cpp:189: return AddFeatures; Since you're ...
6 years, 9 months ago (2014-03-24 16:09:11 UTC) #4
rune
https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/209333005/diff/1/Source/core/css/RuleFeature.cpp#newcode189 Source/core/css/RuleFeature.cpp:189: return AddFeatures; On 2014/03/24 16:09:11, esprehn wrote: > Since ...
6 years, 9 months ago (2014-03-24 17:17:18 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-24 17:17:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/209333005/20001
6 years, 9 months ago (2014-03-24 17:17:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:44:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 17:44:48 UTC) #9
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-24 21:21:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/209333005/20001
6 years, 9 months ago (2014-03-24 21:21:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 21:22:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 21:22:49 UTC) #13
abarth-chromium
This CL saves 54.5% of the time in the main style recalc in toggle_drawer (i.e., ...
6 years, 9 months ago (2014-03-24 21:43:19 UTC) #14
esprehn
All the bubbles are red with build failure?
6 years, 9 months ago (2014-03-24 22:35:07 UTC) #15
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-25 08:14:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/209333005/20001
6 years, 9 months ago (2014-03-25 08:14:56 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 08:56:16 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 08:56:17 UTC) #19
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-25 09:02:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/209333005/20001
6 years, 9 months ago (2014-03-25 09:03:05 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 09:36:39 UTC) #22
Message was sent while issue was closed.
Change committed as 169927

Powered by Google App Engine
This is Rietveld 408576698