Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2093193002:
SkColorSpace::NewICC() warn instead of fail on bad input (Closed)
DescriptionSkColorSpace::NewICC() warn instead of fail on bad input
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002
Committed: https://skia.googlesource.com/skia/+/18895dbb21886214d298a2dfce3fa0839b06beed
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase #
Depends on Patchset: Messages
Total messages: 21 (13 generated)
Description was changed from ========== Warn instead of fail on bad input BUG=skia: ========== to ========== Warn instead of fail on bad input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002 ==========
Description was changed from ========== Warn instead of fail on bad input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002 ========== to ========== SkColorSpace::NewICC() warn instead of fail on bad input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002 ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
msarett@google.com changed reviewers: + brianosman@google.com, reed@google.com
Uncovered a few simple "bugs" while looking at profiles that we fail to parse.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2093193002/diff/40001/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2093193002/diff/40001/src/core/SkColorSpace.c... src/core/SkColorSpace.cpp:299: // It's likely that they're just confused about endianness. What do other parsers do on these? Can you tell what Apple or Adobe do?
https://codereview.chromium.org/2093193002/diff/40001/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2093193002/diff/40001/src/core/SkColorSpace.c... src/core/SkColorSpace.cpp:299: // It's likely that they're just confused about endianness. On 2016/06/25 01:16:37, reed1 wrote: > What do other parsers do on these? Can you tell what Apple or Adobe do? I'm fairly confident that this is the right decision. My test images have perfectly normal sRGB profiles (minus the weird rendering intent). Safari treats these images as sRGB (but that's not too informative because Safari also treats unmarked images as sRGB). Linux command line tool (exiftool) parses the profile just fine. I'm working on getting Adobe Photoshop (finally) but I don't think it'll change my opinion.
lgtm
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== SkColorSpace::NewICC() warn instead of fail on bad input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002 ========== to ========== SkColorSpace::NewICC() warn instead of fail on bad input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093193002 Committed: https://skia.googlesource.com/skia/+/18895dbb21886214d298a2dfce3fa0839b06beed ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://skia.googlesource.com/skia/+/18895dbb21886214d298a2dfce3fa0839b06beed |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
