Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2093143002: Revert of Storage of ComputedStyle separate from LayoutObject. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh, Bugs Nash
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, nainar, rwlbuis, rune, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Storage of ComputedStyle separate from LayoutObject. (patchset #11 id:260001 of https://codereview.chromium.org/1962953002/ ) Reason for revert: Bisect is saying this is causing android per test failures. https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/236 crbug.com/623087 Original issue's description: > Storage of ComputedStyle separate from LayoutObject. > > Part of stage 1 in separation of style resolution and > layout tree construction > Design doc: bit.ly/24nQ9UQ > > Changes the Node::m_data DataUnion to now allow a ComputedStyle. > > Updates Node flags with new flag HasLayoutObject to indicate whether > the DataUnion is a LayoutObject or a ComputedStyle. Adds new > hasLayoutObject method to check flag. > > Updates ComputedStyle and Layoutobject getters and setters accordingly. > > Written with nainar@ > > BUG=595137 > > Committed: https://crrev.com/11af5b8769875ef50b16cb94d7eb758def0d9b08 > Cr-Commit-Position: refs/heads/master@{#401821} TBR=timloh@chromium.org,bugsnash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595137, 623087 Committed: https://crrev.com/cbe9a86098dfc52db1f5a910696a28473a1a54de Cr-Commit-Position: refs/heads/master@{#401898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -64 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 5 chunks +33 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeComputedStyle.h View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
rnephew (Reviews Here)
Created Revert of Storage of ComputedStyle separate from LayoutObject.
4 years, 5 months ago (2016-06-24 17:40:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093143002/1
4 years, 5 months ago (2016-06-24 17:41:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-24 17:42:21 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 17:44:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbe9a86098dfc52db1f5a910696a28473a1a54de
Cr-Commit-Position: refs/heads/master@{#401898}

Powered by Google App Engine
This is Rietveld 408576698