Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 209313002: Modified components ui to address concern of all the time disabled check update button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest sync Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index 217e4729711c7a7a52edfc00a4893a649f334f67..ab0a14407e3a0415e7b85b07c388a8204f4d450d 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -78,16 +78,7 @@ struct CrxComponent {
~CrxComponent();
};
-// Convenience structure to use with component listing / enumeration.
-struct CrxComponentInfo {
- // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
- // class implementation for details.
- std::string id;
- std::string version;
- std::string name;
- CrxComponentInfo();
- ~CrxComponentInfo();
-};
+struct CrxComponentInfo;
// The component update service is in charge of installing or upgrading
// select parts of chrome. Each part is called a component and managed by
@@ -210,6 +201,9 @@ class ComponentUpdateService {
// Returns a list of registered components.
virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
+ // Returns current status of a previously registered component.
+ virtual Status GetComponentStatus(const std::string& component_id) = 0;
+
// Returns a network resource throttle. It means that a component will be
// downloaded and installed before the resource is unthrottled. This is the
// only function callable from the IO thread.
@@ -238,6 +232,18 @@ typedef ComponentUpdateService::Observer ServiceObserver;
ComponentUpdateService* ComponentUpdateServiceFactory(
ComponentUpdateService::Configurator* config);
+// Convenience structure to use with component listing / enumeration.
Sorin Jianu 2014/04/28 22:46:11 For the future, as we want to expose more state in
+struct CrxComponentInfo {
+ // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
+ // class implementation for details.
+ std::string id;
+ std::string version;
+ std::string name;
+ ComponentUpdateService::Status status;
+ CrxComponentInfo();
+ ~CrxComponentInfo();
Sorin Jianu 2014/04/28 22:46:11 maybe dtor not needed?
+};
+
} // namespace component_updater
#endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698