Modified components ui to address concern of all the time disabled check update button.

chrome/browser/component_updater/component_updater_service.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 60 matching lines @@
   std::vector<uint8> pk_hash;
   ComponentInstaller* installer;
   Version version;
   std::string fingerprint;
   std::string name;
   bool allow_background_download;
   CrxComponent();
   ~CrxComponent();
 };
 
-// Convenience structure to use with component listing / enumeration.
-struct CrxComponentInfo {
-  // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
-  // class implementation for details.
-  std::string id;
-  std::string version;
-  std::string name;
-  CrxComponentInfo();
-  ~CrxComponentInfo();
-};
+struct CrxComponentInfo;
 
 // The component update service is in charge of installing or upgrading
 // select parts of chrome. Each part is called a component and managed by
 // instances of CrxComponent registered using RegisterComponent(). On the
 // server, each component is packaged as a CRX which is the same format used
 // to package extensions. To the update service each component is identified
 // by its public key hash (CrxComponent::pk_hash). If there is an update
 // available and its version is bigger than (CrxComponent::version), it will
 // be downloaded, verified and unpacked. Then component-specific installer
 // ComponentInstaller::Install (of CrxComponent::installer) will be called.
@@ skipping 102 matching lines @@
   // will not be canceled.
   virtual Status Stop() = 0;
 
   // Add component to be checked for updates. You can call this method
   // before calling Start().
   virtual Status RegisterComponent(const CrxComponent& component) = 0;
 
   // Returns a list of registered components.
   virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
 
+  // Returns current status of a previously registered component.
+  virtual Status GetComponentStatus(const std::string& component_id) = 0;
+
   // Returns a network resource throttle. It means that a component will be
   // downloaded and installed before the resource is unthrottled. This is the
   // only function callable from the IO thread.
   virtual content::ResourceThrottle* GetOnDemandResourceThrottle(
       net::URLRequest* request, const std::string& crx_id) = 0;
 
   virtual ~ComponentUpdateService() {}
 
   friend class ::ComponentsUI;
   friend class OnDemandTester;
 
  private:
   // Ask the component updater to do an update check for a previously
   // registered component, immediately. If an update or check is already
   // in progress, returns |kInProgress|.
   // There is no guarantee that the item will actually be updated,
   // since an update may not be available. Listeners for the component will
   // know the outcome of the check.
   virtual Status OnDemandUpdate(const std::string& component_id) = 0;
 };
 
 typedef ComponentUpdateService::Observer ServiceObserver;
 
 // Creates the component updater. You must pass a valid |config| allocated on
 // the heap which the component updater will own.
 ComponentUpdateService* ComponentUpdateServiceFactory(
     ComponentUpdateService::Configurator* config);
 
+// Convenience structure to use with component listing / enumeration.

[Sorin Jianu, 2014/04/28 22:46:11]

For the future, as we want to expose more state information, this structure
either will have to include all the state information or we might need to make
CrxUpdateItem available to the page. The page is already a friend of the
service, so extending the encapsulation boundary in that direction is
theoretically possible. I suggest you talk to cpu@ about it. We are not fond of
duplicating members from CrxUpdateItem here nor about the friendship. But one
way or another we want to make the state information available to the page so
developers understand what their component is doing (pretty much, most of the
members of the CrxUpdateItem are useful from a dev standpoint when they are
looking for answer why their updates are not working).

+struct CrxComponentInfo {
+  // |id| is currently derived from |CrxComponent.pk_hash|, see rest of the
+  // class implementation for details.
+  std::string id;
+  std::string version;
+  std::string name;
+  ComponentUpdateService::Status status;
+  CrxComponentInfo();
+  ~CrxComponentInfo();

[Sorin Jianu, 2014/04/28 22:46:11]

maybe dtor not needed?

+};
+
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_