Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2093033003: Fix ResynthesizerResultProvider's handling of parts. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ResynthesizerResultProvider's handling of parts. When attempting to resynthesize a library containing parts from a summary, ResynthesizerResultProvider needs to check whether an analysis target comes from a summary by looking at the analysis target's library source--this is different from AnalysisTarget.source in the case of parts. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/21fb12105a6700d9b75ac3026833da7a9ef7cf3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 4 chunks +9 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 3 chunks +1 line, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 6 months ago (2016-06-24 20:06:34 UTC) #2
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-24 21:39:49 UTC) #3
Paul Berry
4 years, 6 months ago (2016-06-24 22:17:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21fb12105a6700d9b75ac3026833da7a9ef7cf3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698