Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: pkg/analyzer/lib/src/summary/package_bundle_reader.dart

Issue 2093033003: Fix ResynthesizerResultProvider's handling of parts. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/source.dart ('k') | pkg/analyzer/lib/src/task/html.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/package_bundle_reader.dart
diff --git a/pkg/analyzer/lib/src/summary/package_bundle_reader.dart b/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
index 21102db355eaac809ed848fb1ec29730a735e1c1..0055866490ad03745ccab3b0f80abdec02b2b9f7 100644
--- a/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
+++ b/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
@@ -140,7 +140,7 @@ abstract class ResynthesizerResultProvider extends ResultProvider {
}
AnalysisTarget target = entry.target;
// Check whether there are results for the source.
- if (!hasResultsForSource(target.source)) {
+ if (!hasResultsForSource(target.librarySource ?? target.source)) {
return false;
}
// Constant expressions are always resolved in summaries.
@@ -184,9 +184,6 @@ abstract class ResynthesizerResultProvider extends ResultProvider {
return false;
}
} else if (target is LibrarySpecificUnit) {
- if (!hasResultsForSource(target.library)) {
- return false;
- }
if (result == CREATED_RESOLVED_UNIT1 ||
result == CREATED_RESOLVED_UNIT2 ||
result == CREATED_RESOLVED_UNIT3 ||
@@ -213,9 +210,6 @@ abstract class ResynthesizerResultProvider extends ResultProvider {
}
}
} else if (target is VariableElement) {
- if (!hasResultsForSource(target.library.source)) {
- return false;
- }
if (result == PROPAGATED_VARIABLE || result == INFERRED_STATIC_VARIABLE) {
entry.setValue(result, target, TargetedResult.EMPTY_LIST);
return true;
« no previous file with comments | « pkg/analyzer/lib/src/generated/source.dart ('k') | pkg/analyzer/lib/src/task/html.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698