Retract PipelineBuilder some more

Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003

Committed: https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c

[robertphillips, 2016-06-24 19:33:12]

Description was changed from

==========
Retract PipelineBuilder some more
==========

to

==========
Retract PipelineBuilder some more
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

[robertphillips, 2016-07-21 15:18:22]

Description was changed from

==========
Retract PipelineBuilder some more
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

to

==========
Retract PipelineBuilder some more

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

[robertphillips, 2016-07-21 15:18:22]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-07-21 18:20:44]

Description was changed from

==========
Retract PipelineBuilder some more

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

to

==========
Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept
the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the
should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

[robertphillips, 2016-07-21 18:28:52]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-07-21 18:36:06]

lgtm

[commit-bot: I haz the power, 2016-07-21 18:58:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:58:13]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-21 19:03:03]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-21 19:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:04:10]

Description was changed from

==========
Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept
the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the
should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003
==========

to

==========
Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept
the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the
should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003

Committed:
https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c
==========

[commit-bot: I haz the power, 2016-07-21 19:04:11]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c

[bsalomon, 2016-07-22 14:10:03]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2175573004/ by bsalomon@google.com.

The reason for reverting is: skbug.com/5559.

[robertphillips, 2016-07-25 12:19:44]

Description was changed from

==========
Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept
the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the
should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003

Committed:
https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c
==========

to

==========
Retract PipelineBuilder some more

The main part of this CL is widening SkDrawContext::drawBatch's API to accept
the userStencilSettings & drawFace

There is some ancillary spookiness related to expanding the
should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples

Calved off:
https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from
GrPipelineBuilder)
https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path
renderers)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003

Committed:
https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c
==========

[robertphillips, 2016-07-27 19:15:16]

Too painful