Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2092763002: [Interpreter] Maintain a pointer to the current position in the bytecode

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 5 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_cache_fp_and_bytecode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Maintain a pointer to the current position in the bytecode Maintain a pointer to the current position in the bytecode where possible to avoid having to recompute this position based on the bytecode offset and bytecode array pointer on every access to the bytecode. BUG=v8:4280

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -33 lines) Patch
M src/interpreter/interpreter-assembler.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 8 chunks +20 lines, -12 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 7 chunks +22 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092763002/40001
4 years, 6 months ago (2016-06-23 16:44:36 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/3752) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-23 17:02:15 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092763002/60001
4 years, 6 months ago (2016-06-23 19:27:04 UTC) #9
rmcilroy
This also seems to give a couple of points on x64 and arm32. I'll land ...
4 years, 6 months ago (2016-06-23 19:29:05 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 19:53:38 UTC) #13
oth
lgtm, thanks.
4 years, 6 months ago (2016-06-24 09:32:50 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092763002/80001
4 years, 5 months ago (2016-06-24 11:08:00 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-24 11:34:30 UTC) #18
rmcilroy
This actually seems to be mostly a regression on the bots now that the other ...
4 years, 5 months ago (2016-06-24 12:54:46 UTC) #19
rmcilroy
4 years, 5 months ago (2016-06-24 12:54:46 UTC) #20
This actually seems to be mostly a regression on the bots now that the other CL
has landed. I'll park this for now and maybe look into it further later.

Powered by Google App Engine
This is Rietveld 408576698