Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2085353005: [Interpreter] Maintain the parent frame pointer after load (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_globals
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Maintain the parent frame pointer after load Maintain the parent frame pointer in a variable after loading it to avoid having to reload it each time it is required. BUG=v8:4280 Committed: https://crrev.com/361548ca4ca94663208f3354319f0b92812b1c54 Cr-Commit-Position: refs/heads/master@{#37247}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M src/interpreter/interpreter-assembler.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 4 chunks +14 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085353005/20001
4 years, 6 months ago (2016-06-23 16:33:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 17:01:26 UTC) #6
rmcilroy
Orion: seems to have a couple of percentage point improvement on Octane-noopt. PTAL, thanks.
4 years, 6 months ago (2016-06-23 17:19:16 UTC) #8
oth
lgtm. Nice set of perf bumps with this CL :-) https://codereview.chromium.org/2085353005/diff/20001/src/interpreter/interpreter-assembler.h File src/interpreter/interpreter-assembler.h (right): https://codereview.chromium.org/2085353005/diff/20001/src/interpreter/interpreter-assembler.h#newcode171 ...
4 years, 6 months ago (2016-06-24 09:27:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085353005/20001
4 years, 6 months ago (2016-06-24 09:45:58 UTC) #11
rmcilroy
https://codereview.chromium.org/2085353005/diff/20001/src/interpreter/interpreter-assembler.h File src/interpreter/interpreter-assembler.h (right): https://codereview.chromium.org/2085353005/diff/20001/src/interpreter/interpreter-assembler.h#newcode171 src/interpreter/interpreter-assembler.h:171: // Returns the frame point for the interpreted frame ...
4 years, 6 months ago (2016-06-24 09:48:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085353005/40001
4 years, 6 months ago (2016-06-24 09:48:18 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-24 10:14:13 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 10:16:56 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/361548ca4ca94663208f3354319f0b92812b1c54
Cr-Commit-Position: refs/heads/master@{#37247}

Powered by Google App Engine
This is Rietveld 408576698