Issue 209263002: Merge 257570 "Handle cases when user cert database has NULL slots"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209263002: Merge 257570 "Handle cases when user cert database has NULL slots" (Closed)

Created:
6 years, 9 months ago by tbarzic

Modified:
6 years, 9 months ago

Reviewers:
tbarzic

CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

More Reviews

Description

Merge 257570 "Handle cases when user cert database has NULL slots" > Handle cases when user cert database has NULL slots > > The slots can be NULL if the user's username hash is empty string (e.g. in retail mode) > > BUG=349085, 340505 > TEST= > Retail mode does not immediately restart (i.e. no crash). > In retail mode, go to chrome://settings/certificates -> buttons for importing certs should be disabled > > Review URL: https://codereview.chromium.org/193273002 TBR=tbarzic@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258733

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -13 lines)			Patch
M	chrome/browser/certificate_manager_model.h	View	4 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/certificate_manager_model.cc	View	4 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/certificate_manager.js	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/certificate_manager_browsertest.js	View	3 chunks	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/certificate_manager_handler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/cert_loader.cc	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	chromeos/cert_loader_unittest.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	chromeos/network/onc/onc_certificate_importer_impl.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tbarzic

6 years, 9 months ago (2014-03-22 01:16:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r258733 (tree was closed).

Expand Messages | Collapse Messages