Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 193273002: Handle cases when user cert database has NULL slots (Closed)

Created:
6 years, 9 months ago by tbarzic
Modified:
6 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Handle cases when user cert database has NULL slots The slots can be NULL if the user's username hash is empty string (e.g. in retail mode) BUG=349085, 340505 TEST= Retail mode does not immediately restart (i.e. no crash). In retail mode, go to chrome://settings/certificates -> buttons for importing certs should be disabled Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257570

Patch Set 1 #

Patch Set 2 : onc_certificate_importer #

Patch Set 3 : certificate manager import #

Patch Set 4 : . #

Patch Set 5 : webui tests #

Patch Set 6 : new cert loader test #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : document is_user_db_available #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -13 lines) Patch
M chrome/browser/certificate_manager_model.h View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/certificate_manager_model.cc View 1 2 3 4 5 4 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/certificate_manager.js View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 2 3 4 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/cert_loader.cc View 1 2 3 4 5 2 chunks +13 lines, -3 lines 0 comments Download
M chromeos/cert_loader_unittest.cc View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tbarzic
stevenjb: owner for chromeos/ parts jhawkins: owner for chrome/ parts
6 years, 9 months ago (2014-03-12 18:46:54 UTC) #1
stevenjb
owner lgtm
6 years, 9 months ago (2014-03-12 19:33:38 UTC) #2
mattm
lgtm
6 years, 9 months ago (2014-03-13 01:11:25 UTC) #3
tbarzic
jhawkins: ping
6 years, 9 months ago (2014-03-17 18:42:13 UTC) #4
James Hawkins
LGTM with nit. https://codereview.chromium.org/193273002/diff/110001/chrome/browser/certificate_manager_model.h File chrome/browser/certificate_manager_model.h (right): https://codereview.chromium.org/193273002/diff/110001/chrome/browser/certificate_manager_model.h#newcode154 chrome/browser/certificate_manager_model.h:154: bool is_user_db_available_; It's not clear to ...
6 years, 9 months ago (2014-03-17 18:58:21 UTC) #5
tbarzic
https://codereview.chromium.org/193273002/diff/110001/chrome/browser/certificate_manager_model.h File chrome/browser/certificate_manager_model.h (right): https://codereview.chromium.org/193273002/diff/110001/chrome/browser/certificate_manager_model.h#newcode154 chrome/browser/certificate_manager_model.h:154: bool is_user_db_available_; On 2014/03/17 18:58:22, James Hawkins wrote: > ...
6 years, 9 months ago (2014-03-17 19:17:37 UTC) #6
James Hawkins
Thanks, LG.
6 years, 9 months ago (2014-03-17 19:18:34 UTC) #7
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 9 months ago (2014-03-17 20:22:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/193273002/150001
6 years, 9 months ago (2014-03-17 20:23:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 22:47:28 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-17 22:47:30 UTC) #11
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 9 months ago (2014-03-18 00:02:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/193273002/150001
6 years, 9 months ago (2014-03-18 00:03:47 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 01:29:14 UTC) #14
Message was sent while issue was closed. 
Change committed as 257570

Powered by Google App Engine
This is Rietveld 408576698