Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2092463002: Move memory-infra check from background tracing and whitelist memory dump args (Closed)

Created:
4 years, 6 months ago by ssid
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enabled_modes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move memory-infra check from background tracing and whitelist memory dump args BUG=613198 Committed: https://crrev.com/7d2fd66cc632f2fcf5fb821936cdac319f7f8233 Cr-Commit-Position: refs/heads/master@{#401652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
ssid
+primiano, oysteine This cleans up background tracing a bit and adds args to whitelist. ptal, ...
4 years, 6 months ago (2016-06-22 17:26:19 UTC) #3
oystein (OOO til 10th of July)
Perfect! lgtm
4 years, 6 months ago (2016-06-23 08:44:20 UTC) #6
Primiano Tucci (use gerrit)
LGTM. The line in MDM seems a bit too wrapped but not a huge deal.
4 years, 6 months ago (2016-06-23 14:02:35 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092463002/20001
4 years, 6 months ago (2016-06-23 16:32:32 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 18:02:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092463002/20001
4 years, 6 months ago (2016-06-23 18:07:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-23 18:14:10 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d2fd66cc632f2fcf5fb821936cdac319f7f8233 Cr-Commit-Position: refs/heads/master@{#401652}
4 years, 6 months ago (2016-06-23 18:51:10 UTC) #17
dgozman
4 years, 6 months ago (2016-06-23 21:26:37 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2095593003/ by dgozman@chromium.org.

The reason for reverting is: Speculative revert. Looks like this could have
broken mac and linux sizes:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21314.

Powered by Google App Engine
This is Rietveld 408576698