Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: content/browser/tracing/background_tracing_manager_impl.cc

Issue 2092463002: Move memory-infra check from background tracing and whitelist memory dump args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enabled_modes
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/trace_event_args_whitelist.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/background_tracing_manager_impl.cc
diff --git a/content/browser/tracing/background_tracing_manager_impl.cc b/content/browser/tracing/background_tracing_manager_impl.cc
index 14746163c2cd28098ffb8de72a0e58835f278103..c5812f959222d2bee9c54a6955616471d0a5e320 100644
--- a/content/browser/tracing/background_tracing_manager_impl.cc
+++ b/content/browser/tracing/background_tracing_manager_impl.cc
@@ -52,10 +52,6 @@ void RecordBackgroundTracingMetric(BackgroundTracingMetrics metric) {
// Tracing enabled callback for BENCHMARK_MEMORY_LIGHT category preset.
void BenchmarkMemoryLight_TracingEnabledCallback() {
auto dump_manager = base::trace_event::MemoryDumpManager::GetInstance();
- // Safety check to make sure the memory-infra restrictions are properly
- // propagated via TraceConfig
- CHECK(!dump_manager->IsDumpModeAllowed(
- base::trace_event::MemoryDumpLevelOfDetail::DETAILED));
dump_manager->RequestGlobalDump(
base::trace_event::MemoryDumpType::EXPLICITLY_TRIGGERED,
base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND);
« no previous file with comments | « chrome/common/trace_event_args_whitelist.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698