Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
index ee2852c9168010a94bdb6b024811f0ffc12bba93..7212baecbdcfd432454f6d868dee28d7a9d2a594 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
@@ -109,6 +109,7 @@ void PopupBlockerTabHelper::AddBlockedPopup(
nav_params.tabstrip_add_types = TabStripModel::ADD_ACTIVE;
nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW;
nav_params.user_gesture = user_gesture;
+ nav_params.should_set_opener = !opener_suppressed;
Charlie Reis 2013/08/01 18:13:34 What if we just had a nav_params.opener_contents t
jochen (gone - plz use gerrit) 2013/08/01 19:48:51 chrome::NavigateParams already has source_contents
web_contents()->GetView()->GetContainerBounds(&nav_params.window_bounds);
if (features.xSet)
nav_params.window_bounds.set_x(features.x);

Powered by Google App Engine
This is Rietveld 408576698