Try to restore window.opener when opening blocked popups

chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 91 matching lines @@
   chrome::NavigateParams nav_params(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()),
       target_url,
       content::PAGE_TRANSITION_LINK);
   nav_params.referrer = referrer;
   nav_params.source_contents = web_contents();
   nav_params.is_renderer_initiated = true;
   nav_params.tabstrip_add_types = TabStripModel::ADD_ACTIVE;
   nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW;
   nav_params.user_gesture = user_gesture;
+  nav_params.should_set_opener = !opener_suppressed;

[Charlie Reis, 2013/08/01 18:13:34]

What if we just had a nav_params.opener_contents that we set to web_contents()
if !opener_suppressed?  Then we don't need to change the WebContents::Create
API.

[jochen (gone - plz use gerrit), 2013/08/01 19:48:51]

chrome::NavigateParams already has source_contents, so I'd say a bool is enough
here. Changing WebContents::CreateParams is a good idea, I will do that.

   web_contents()->GetView()->GetContainerBounds(&nav_params.window_bounds);
   if (features.xSet)
     nav_params.window_bounds.set_x(features.x);
   if (features.ySet)
     nav_params.window_bounds.set_y(features.y);
   if (features.widthSet)
     nav_params.window_bounds.set_width(features.width);
   if (features.heightSet)
     nav_params.window_bounds.set_height(features.height);
 
@@ skipping 29 matching lines @@
 std::map<int32, GURL> PopupBlockerTabHelper::GetBlockedPopupRequests() {
   std::map<int32, GURL> result;
   for (IDMap<BlockedRequest, IDMapOwnPointer>::const_iterator iter(
            &blocked_popups_);
        !iter.IsAtEnd();
        iter.Advance()) {
     result[iter.GetCurrentKey()] = iter.GetCurrentValue()->params.url;
   }
   return result;
 }