[MD Settings] Add a menu option to clear a cached credit card.

chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-passwords-and-forms-page' is the settings page
  * for passwords and auto fill.
  */
 
 /**
@@ skipping 98 matching lines @@
    * @param {function(!Array<!AutofillManager.AddressEntry>):void} listener
    */
   removeAddressListChangedListener: assertNotReached,
 
   /**
    * Request the list of addresses.
    * @param {function(!Array<!AutofillManager.AddressEntry>):void} callback
    */
   getAddressList: assertNotReached,
 
-  /** @param {!AutofillManager.AddressEntry} address The address to remove.  */
+  /** @param {string} guid The guid of the address to remove.  */
   removeAddress: assertNotReached,
 
   /**
    * Add an observer to the list of credit cards.
    * @param {function(!Array<!AutofillManager.CreditCardEntry>):void} listener
    */
   addCreditCardListChangedListener: assertNotReached,
 
   /**
    * Remove an observer from the list of credit cards.
    * @param {function(!Array<!AutofillManager.CreditCardEntry>):void} listener
    */
   removeCreditCardListChangedListener: assertNotReached,
 
   /**
    * Request the list of credit cards.
    * @param {function(!Array<!AutofillManager.CreditCardEntry>):void} callback
    */
   getCreditCardList: assertNotReached,
 
-  /**
-   * @param {!AutofillManager.CreditCardEntry} creditCard The credit card to
-   *     remove.
-   */
+  /** @param {string} guid The GUID of the credit card to remove.  */
   removeCreditCard: assertNotReached,
 
+  /** @param {string} guid The GUID to credit card to remove from the cache. */
+  clearCachedCreditCard: assertNotReached,
+
   /**
    * Saves the given credit card.
    * @param {!AutofillManager.CreditCardEntry} creditCard
    */
   saveCreditCard: assertNotReached,
 };
 
 /**
  * Implementation that accesses the private API.
  * @implements {PasswordManager}
@@ skipping 84 matching lines @@
   removeAddressListChangedListener: function(listener) {
     chrome.autofillPrivate.onAddressListChanged.removeListener(listener);
   },
 
   /** @override */
   getAddressList: function(callback) {
     chrome.autofillPrivate.getAddressList(callback);
   },
 
   /** @override */
-  removeAddress: function(address) {
-    chrome.autofillPrivate.removeEntry(/** @type {string} */(address.guid));
+  removeAddress: function(guid) {
+    // GUID identifies an address: can't delete one if you don't know which

[tommycli, 2016/06/27 22:31:28]

The assert is pretty self explanatory. No need for the comments on them IMO.

[hcarmona, 2016/06/27 22:42:13]

👍

+    // address.
+    assert(guid);
+    chrome.autofillPrivate.removeEntry(guid);
   },
 
   /** @override */
   addCreditCardListChangedListener: function(listener) {
     chrome.autofillPrivate.onCreditCardListChanged.addListener(listener);
   },
 
   /** @override */
   removeCreditCardListChangedListener: function(listener) {
     chrome.autofillPrivate.onCreditCardListChanged.removeListener(listener);
   },
 
   /** @override */
   getCreditCardList: function(callback) {
     chrome.autofillPrivate.getCreditCardList(callback);
   },
 
   /** @override */
-  removeCreditCard: function(creditCard) {
-    chrome.autofillPrivate.removeEntry(/** @type {string} */(creditCard.guid));
+  removeCreditCard: function(guid) {
+    // GUID identifies a credit card: can't delete one if you don't know which
+    // credit card.
+    assert(guid);
+    chrome.autofillPrivate.removeEntry(guid);
   },
 
   /** @override */
+  clearCachedCreditCard: function(guid) {
+    // GUID identifies a credit card: can't clear cache if you don't know which
+    // credit card.
+    assert(guid);
+    chrome.autofillPrivate.maskCreditCard(guid);
+  },
+
+  /** @override */
   saveCreditCard: function(creditCard) {
     chrome.autofillPrivate.saveCreditCard(creditCard);
   }
 };
 
 (function() {
 'use strict';
 
 Polymer({
   is: 'settings-passwords-and-forms-page',
@@ skipping 34 matching lines @@
     addresses: Array,
 
     /**
      * An array of saved addresses.
      * @type {!Array<!AutofillManager.CreditCardEntry>}
      */
     creditCards: Array,
  },
 
   listeners: {
+    'clear-credit-card': 'clearCreditCard_',
     'remove-address': 'removeAddress_',
     'remove-credit-card': 'removeCreditCard_',
     'remove-password-exception': 'removePasswordException_',
     'remove-saved-password': 'removeSavedPassword_',
     'save-credit-card': 'saveCreditCard_',
     'show-password': 'showPassword_',
   },
 
   /** @type {?function(!Array<PasswordManager.PasswordUiEntry>):void} */
   setSavedPasswordsListener_: null,
@@ skipping 76 matching lines @@
   removeSavedPassword_: function(event) {
     this.passwordManager_.removeSavedPassword(event.detail);
   },
 
   /**
    * Listens for the remove-address event, and calls the private API.
    * @param {!Event} event
    * @private
    */
   removeAddress_: function(event) {
-    this.autofillManager_.removeAddress(event.detail);
+    this.autofillManager_.removeAddress(event.detail.guid);
   },
 
   /**
    * Listens for the remove-credit-card event, and calls the private API.
    * @param {!Event} event
    * @private
    */
   removeCreditCard_: function(event) {
-    this.autofillManager_.removeCreditCard(event.detail);
+    this.autofillManager_.removeCreditCard(event.detail.guid);
   },
 
   /**
+   * Listens for the clear-credit-card event, and calls the private API.
+   * @param {!Event} event
+   * @private
+   */
+  clearCreditCard_: function(event) {
+    this.autofillManager_.clearCachedCreditCard(event.detail.guid);
+  },
+
+  /**
    * Shows the manage autofill sub page.
    * @param {!Event} event
    * @private
    */
   onAutofillTap_: function(event) {
     // Ignore clicking on the toggle button and verify autofill is enabled.
     if (Polymer.dom(event).localTarget != this.$.autofillToggle &&
         this.getPref('autofill.enabled').value) {
       this.$.pages.setSubpageChain(['manage-autofill']);
     }
@@ skipping 27 matching lines @@
    * @param {!Event} event
    * @private
    */
   showPassword_: function(event) {
     this.passwordManager_.getPlaintextPassword(event.detail, function(e) {
       this.$$('#passwordSection').setPassword(e.loginPair, e.plaintextPassword);
     }.bind(this));
   },
 });
 })();