Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2092283002: Revert of Enable subframe FrameNavigationEntries by default. (Closed)

Created:
4 years, 6 months ago by Charlie Reis
Modified:
4 years, 6 months ago
Reviewers:
ncarter (slow), boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable subframe FrameNavigationEntries by default. (patchset #4 id:60001 of https://codereview.chromium.org/1952533003/ ) Reason for revert: Caused several layout tests to fail: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=6083 fast/history/same-document-iframes-changing-fragment.html [ Failure ] fast/history/same-document-iframes-changing-pushstate.html [ Failure ] fast/loader/form-state-restore-with-frames.html [ Failure ] http/tests/misc/resource-timing-iframe-restored-from-history.html [ Failure ] http/tests/navigation/back-to-dynamic-iframe.html [ Failure ] http/tests/navigation/back-to-redirect-with-frame.php [ Failure ] http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Failure ] Original issue's description: > Enable subframe FrameNavigationEntries by default. > > This is a major change to the navigation logic in Chrome, making > the browser process responsible for selecting subframes to > navigate. Each NavigationEntry now has a tree of > FrameNavigationEntries representing each frame in the page, and > these frame entries track per-frame PageState. > > HistoryController in content/renderer is no longer used, since > equivalent code in NavigationController in content/browser now > determines which frames to navigate. > > This CL is designed to be easy to revert if regressions are > found, though the new path has been in use on 50% of Canary and > Dev channels for a while. > > BUG=236848 > TEST=Existing tests pass. > > Committed: https://crrev.com/810a396cc50315037a51e55342da6c04d1c9b260 > Cr-Commit-Position: refs/heads/master@{#401969} TBR=boliu@chromium.org,nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=236848 Committed: https://crrev.com/5e66abf8057e5e904c9539ee8aa2fe92161d208f Cr-Commit-Position: refs/heads/master@{#401985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/site_isolation_policy.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Charlie Reis
Created Revert of Enable subframe FrameNavigationEntries by default.
4 years, 6 months ago (2016-06-24 21:49:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092283002/1
4 years, 6 months ago (2016-06-24 21:50:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 21:51:27 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 21:54:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e66abf8057e5e904c9539ee8aa2fe92161d208f
Cr-Commit-Position: refs/heads/master@{#401985}

Powered by Google App Engine
This is Rietveld 408576698