[system-health] Generalize loading stories to single-page stories

[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/4a1564f3aac9977033002f4f2537ff3bc2fa62ca
Cr-Commit-Position: refs/heads/master@{#402494}

[petrcermak, 2016-06-24 16:48:16]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-06-24 16:48:16]

PTAL.

Thanks,
Petr

[nednguyen, 2016-06-24 17:08:26]

https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:97: def Resolve(self,
platform_name):
It seems to me that we are going down to the path of declarative json page set
(https://bugs.chromium.org/p/chromium/issues/detail?id=239179)

How is this more simpler than just create a bunch of page classes? My worry with
this kind of strategy is it makes it harder for new comers to know how to
fix/tweaks the page behaviors when they need to.

[petrcermak, 2016-06-27 19:31:21]

Thanks for your feedback. PTAL.

Petr

https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:97: def Resolve(self,
platform_name):
On 2016/06/24 17:08:26, nednguyen wrote:
> It seems to me that we are going down to the path of declarative json page set
> (https://bugs.chromium.org/p/chromium/issues/detail?id=239179)
> 
> How is this more simpler than just create a bunch of page classes? My worry
with
> this kind of strategy is it makes it harder for new comers to know how to
> fix/tweaks the page behaviors when they need to.

You're right. I rewrote the file completely ;-)

[nednguyen, 2016-06-27 22:32:10]

The ovearll structure lg2me. Don't you need to update the battor benchmark also?

https://codereview.chromium.org/2092163002/diff/20001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2092163002/diff/20001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/single_page_stories.py:56: def
_DocumentLoaded(self, action_runner):
Rename this to _DidLoadDocument?

[perezju, 2016-06-28 09:56:45]

On 2016/06/27 19:31:21, petrcermak wrote:
> Thanks for your feedback. PTAL.
> 
> Petr
> 
>
https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
> File tools/perf/page_sets/system_health/single_page_stories.py (right):
> 
>
https://codereview.chromium.org/2092163002/diff/1/tools/perf/page_sets/system...
> tools/perf/page_sets/system_health/single_page_stories.py:97: def
Resolve(self,
> platform_name):
> On 2016/06/24 17:08:26, nednguyen wrote:
> > It seems to me that we are going down to the path of declarative json page
set
> > (https://bugs.chromium.org/p/chromium/issues/detail?id=239179)
> > 
> > How is this more simpler than just create a bunch of page classes? My worry
> with
> > this kind of strategy is it makes it harder for new comers to know how to
> > fix/tweaks the page behaviors when they need to.
> 
> You're right. I rewrote the file completely ;-)

nice work!

[petrcermak, 2016-06-28 13:18:33]

Description was changed from

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
==========

to

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-06-28 13:21:02]

Patchset #3 (id:40001) has been deleted

[petrcermak, 2016-06-28 13:21:37]

Thanks for your comments. I updated the BattOr benchmarks accordingly. PTAL.

Petr

https://codereview.chromium.org/2092163002/diff/20001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2092163002/diff/20001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/single_page_stories.py:56: def
_DocumentLoaded(self, action_runner):
On 2016/06/27 22:32:09, nednguyen wrote:
> Rename this to _DidLoadDocument?

Done.

[nednguyen, 2016-06-28 14:20:09]

lgtm

[petrcermak, 2016-06-28 14:25:28]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-28 14:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-06-28 15:49:56]

Description was changed from

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-06-28 15:50:01]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-28 15:50:07]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-28 15:50:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-06-28 15:50:55]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-28 15:51:08]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-28 15:51:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 17:06:54]

Description was changed from

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-06-28 17:06:54]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-28 17:09:42]

Description was changed from

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Generalize loading stories to single-page stories

This is a preparation step for implementing interaction stories (see
https://goo.gl/Jek2NL), which are also single-page stories.

BUG=589726
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/4a1564f3aac9977033002f4f2537ff3bc2fa62ca
Cr-Commit-Position: refs/heads/master@{#402494}
==========

[commit-bot: I haz the power, 2016-06-28 17:09:43]

Patchset 3 (id:??) landed as
https://crrev.com/4a1564f3aac9977033002f4f2537ff3bc2fa62ca
Cr-Commit-Position: refs/heads/master@{#402494}