tools/perf/benchmarks/system_health.py - Issue 2092163002: [system-health] Generalize loading stories to single-page stories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2092163002: [system-health] Generalize loading stories to single-page stories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase & address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/system_health.py

diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py

index 8aa389efd739c7bf11bbd29be64adc56f9c0e18c..99e8f037efabc27f819809f96bf30ea9501a4375 100644

--- a/tools/perf/benchmarks/system_health.py

+++ b/tools/perf/benchmarks/system_health.py

@@ -91,7 +91,7 @@ class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):

class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):

"""Desktop Chrome Memory System Health Benchmark."""

- page_set = page_sets.DesktopMemorySystemHealthStorySet

+ page_set = page_sets.DesktopSystemHealthStorySet

@classmethod

def ShouldDisable(cls, possible_browser):

@@ -100,7 +100,7 @@ class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):

class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):

"""Mobile Chrome Memory System Health Benchmark."""

- page_set = page_sets.MobileMemorySystemHealthStorySet

+ page_set = page_sets.MobileSystemHealthStorySet

@classmethod

def ShouldDisable(cls, possible_browser):

« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »