Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2092133002: [Mac/GN] Add missing -Wobjc-missing-property-synthesis. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add missing -Wobjc-missing-property-synthesis. This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE define. BUG=622889 R=dpranke@chromium.org TBR=rohitrao@chromium.org Committed: https://crrev.com/227e59731da9ca04c4ceb9c6cb4725a07e15c199 Cr-Commit-Position: refs/heads/master@{#401984}

Patch Set 1 #

Patch Set 2 : Move to chromium_code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/class-dump/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Robert Sesek
4 years, 6 months ago (2016-06-24 14:57:52 UTC) #1
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-24 15:48:01 UTC) #3
Robert Sesek
+rohitrao for //third_party/class-dump OWNERS
4 years, 6 months ago (2016-06-24 16:38:55 UTC) #5
Robert Sesek
On 2016/06/24 16:38:55, Robert Sesek wrote: > +rohitrao for //third_party/class-dump OWNERS Going to TBR
4 years, 6 months ago (2016-06-24 21:16:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092133002/40001
4 years, 6 months ago (2016-06-24 21:16:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-24 21:50:59 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/227e59731da9ca04c4ceb9c6cb4725a07e15c199 Cr-Commit-Position: refs/heads/master@{#401984}
4 years, 6 months ago (2016-06-24 21:52:33 UTC) #13
rohitrao (ping after 24h)
LGTM Why do we disallow automatic property synthesis?
4 years, 5 months ago (2016-06-27 10:24:42 UTC) #14
Robert Sesek
On 2016/06/27 10:24:42, rohitrao wrote: > LGTM > > Why do we disallow automatic property ...
4 years, 5 months ago (2016-06-27 15:20:54 UTC) #15
Robert Sesek
4 years, 5 months ago (2016-06-27 15:21:09 UTC) #16
Message was sent while issue was closed.
On 2016/06/27 15:20:54, Robert Sesek wrote:
> On 2016/06/27 10:24:42, rohitrao wrote:
> > LGTM
> > 
> > Why do we disallow automatic property synthesis?
> 
> I don't know. We do in GY :)

*GYP

Powered by Google App Engine
This is Rietveld 408576698