[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org

Committed: https://crrev.com/227e59731da9ca04c4ceb9c6cb4725a07e15c199
Cr-Commit-Position: refs/heads/master@{#401984}

[Robert Sesek, 2016-06-24 15:45:24]

Patchset #2 (id:20001) has been deleted

[Dirk Pranke, 2016-06-24 15:48:01]

lgtm

[Robert Sesek, 2016-06-24 16:38:54]

rsesek@chromium.org changed reviewers:
+ rohitrao@chromium.org

[Robert Sesek, 2016-06-24 16:38:55]

+rohitrao for //third_party/class-dump OWNERS

[Robert Sesek, 2016-06-24 21:16:04]

Description was changed from

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
==========

to

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org
==========

[Robert Sesek, 2016-06-24 21:16:10]

On 2016/06/24 16:38:55, Robert Sesek wrote:
> +rohitrao for //third_party/class-dump OWNERS

Going to TBR

[Robert Sesek, 2016-06-24 21:16:31]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:50:58]

Description was changed from

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org
==========

to

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 21:50:59]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-24 21:52:32]

Description was changed from

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org
==========

to

==========
[Mac/GN] Add missing -Wobjc-missing-property-synthesis.

This also adds a missing __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE
define.

BUG=622889
R=dpranke@chromium.org
TBR=rohitrao@chromium.org

Committed: https://crrev.com/227e59731da9ca04c4ceb9c6cb4725a07e15c199
Cr-Commit-Position: refs/heads/master@{#401984}
==========

[commit-bot: I haz the power, 2016-06-24 21:52:33]

Patchset 2 (id:??) landed as
https://crrev.com/227e59731da9ca04c4ceb9c6cb4725a07e15c199
Cr-Commit-Position: refs/heads/master@{#401984}

[rohitrao (ping after 24h), 2016-06-27 10:24:42]

LGTM

Why do we disallow automatic property synthesis?

[Robert Sesek, 2016-06-27 15:20:54]

On 2016/06/27 10:24:42, rohitrao wrote:
> LGTM
> 
> Why do we disallow automatic property synthesis?

I don't know. We do in GY :)

[Robert Sesek, 2016-06-27 15:21:09]

On 2016/06/27 15:20:54, Robert Sesek wrote:
> On 2016/06/27 10:24:42, rohitrao wrote:
> > LGTM
> > 
> > Why do we disallow automatic property synthesis?
> 
> I don't know. We do in GY :)

*GYP