Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2092133002: [Mac/GN] Add missing -Wobjc-missing-property-synthesis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to chromium_code. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/mac/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1043 matching lines...) Expand 10 before | Expand all | Expand 10 after
1054 # _FORTIFY_SOURCE isn't really supported by Clang now, see 1054 # _FORTIFY_SOURCE isn't really supported by Clang now, see
1055 # http://llvm.org/bugs/show_bug.cgi?id=16821. 1055 # http://llvm.org/bugs/show_bug.cgi?id=16821.
1056 # It seems to work fine with Ubuntu 12 headers though, so use it in 1056 # It seems to work fine with Ubuntu 12 headers though, so use it in
1057 # official builds. 1057 # official builds.
1058 # 1058 #
1059 # Non-chromium code is not guaranteed to compile cleanly with 1059 # Non-chromium code is not guaranteed to compile cleanly with
1060 # _FORTIFY_SOURCE. Also, fortified build may fail when optimizations are 1060 # _FORTIFY_SOURCE. Also, fortified build may fail when optimizations are
1061 # disabled, so only do that for Release build. 1061 # disabled, so only do that for Release build.
1062 defines += [ "_FORTIFY_SOURCE=2" ] 1062 defines += [ "_FORTIFY_SOURCE=2" ]
1063 } 1063 }
1064
1065 if (is_mac) {
1066 # Warn if automatic synthesis is triggered. This triggers numerous
1067 # warnings for internal iOS directories.
1068 cflags_objc = [ "-Wobjc-missing-property-synthesis" ]
1069 cflags_objcc = [ "-Wobjc-missing-property-synthesis" ]
1070 }
1064 } 1071 }
1065 1072
1066 configs = [ ":default_warnings" ] 1073 configs = [ ":default_warnings" ]
1067 } 1074 }
1068 1075
1069 config("no_chromium_code") { 1076 config("no_chromium_code") {
1070 cflags = [] 1077 cflags = []
1071 cflags_cc = [] 1078 cflags_cc = []
1072 defines = [] 1079 defines = []
1073 1080
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
1541 1548
1542 if (is_ios || is_mac) { 1549 if (is_ios || is_mac) {
1543 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1550 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1544 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1551 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1545 config("enable_arc") { 1552 config("enable_arc") {
1546 common_flags = [ "-fobjc-arc" ] 1553 common_flags = [ "-fobjc-arc" ]
1547 cflags_objc = common_flags 1554 cflags_objc = common_flags
1548 cflags_objcc = common_flags 1555 cflags_objcc = common_flags
1549 } 1556 }
1550 } 1557 }
OLDNEW
« no previous file with comments | « no previous file | build/config/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698