Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2091973002: [arm] Eliminate OperandConverter Float32 and Float64 register methods. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Eliminate OperandConverter Float32 and Float64 register methods. Removes OperandConverter::*Float32* and *Float64* methods. LOG=N BUG=v8:4124 Committed: https://crrev.com/2db846d531878ef322b0dab6ffb4e394beb86fd6 Cr-Commit-Position: refs/heads/master@{#37285}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -165 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 21 chunks +131 lines, -163 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bbudge
This patchset depends on the register aliasing one. I'll rebase after that lands. Only the ...
4 years, 6 months ago (2016-06-24 00:09:52 UTC) #2
bbudge
This is ready. PTAL
4 years, 5 months ago (2016-06-25 21:17:56 UTC) #4
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-27 03:59:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091973002/40001
4 years, 5 months ago (2016-06-27 11:14:36 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 11:39:08 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 11:40:17 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2db846d531878ef322b0dab6ffb4e394beb86fd6
Cr-Commit-Position: refs/heads/master@{#37285}

Powered by Google App Engine
This is Rietveld 408576698