Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: src/compiler/instruction.h

Issue 2091973002: [arm] Eliminate OperandConverter Float32 and Float64 register methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index 6e9480bf7b92fc319141d2cc1c453ba67d688c4a..af7e592e5f93c4a0596c3c6d7b280c3160faca15 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -439,8 +439,9 @@ class LocationOperand : public InstructionOperand {
}
DoubleRegister GetDoubleRegister() const {
- // TODO(bbudge) Tighten this test to IsDoubleRegister when all code
- // generators are changed to use the correct Get*Register method.
+ // On platforms where FloatRegister, DoubleRegister, and Simd128Register
+ // are all the same type, it's convenient to treat everything as a
+ // DoubleRegister, so be lax about type checking here.
DCHECK(IsFPRegister());
return DoubleRegister::from_code(register_code());
}
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698