chrome/browser/web_dev_style/test_util.py - Issue 2091903002: [Presubmit] check for single quotes in html properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/test_util.py

Issue 2091903002: [Presubmit] check for single quotes in html properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: multi-line Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_dev_style/test_util.py

diff --git a/chrome/browser/web_dev_style/test_util.py b/chrome/browser/web_dev_style/test_util.py

index a613d75d8e8e0af57a78334303fc3b33a4b842bf..850abb090dbe951adef0fb96aad217777eee1ee1 100644

--- a/chrome/browser/web_dev_style/test_util.py

+++ b/chrome/browser/web_dev_style/test_util.py

@@ -6,5 +6,8 @@

def GetHighlight(line, error):

"""Returns the substring of |line| that is highlighted in |error|."""

error_lines = error.split('\n')

+ # TODO(dschuyler): delve into multi-line errors further.

Dan Beam 2016/06/25 00:49:03 what's the issue here exactly?

dschuyler 2016/06/28 19:04:18 Changed comment to better explain. Done.

+ if line not in error_lines:

+ return line

highlight = error_lines[error_lines.index(line) + 1]

return ''.join(ch1 for (ch1, ch2) in zip(line, highlight) if ch2 == '^')

« chrome/browser/web_dev_style/html_checker_test.py ('K') | « chrome/browser/web_dev_style/html_checker_test.py ('k') | no next file » | no next file with comments »