Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2091803002: Logging and tracing of audio devices on Andriod. (Closed)

Created:
4 years, 6 months ago by Max Morin WebRTC
Modified:
4 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Logging and tracing of audio devices on Andriod. Replaced invokations of WEBRTC_TRACE with LOG, which is visible in the android system log. BUG=NONE R=henrika@webrtc.org Committed: https://crrev.com/098e6c5d0a07a767c97dea14a2ebfc13b1ee23aa Cr-Commit-Position: refs/heads/master@{#13308}

Patch Set 1 #

Total comments: 15

Patch Set 2 : Also log arguments and return values. Move spammy messages to LS_VERBOSE. #

Total comments: 1

Patch Set 3 : Move moderatly verbose traces to INFO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -195 lines) Patch
M webrtc/modules/audio_device/android/audio_device_template.h View 1 2 18 chunks +71 lines, -14 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 1 2 130 chunks +317 lines, -181 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Max Morin WebRTC
4 years, 6 months ago (2016-06-23 15:01:10 UTC) #3
henrika_webrtc
Thanks. Some initial comments. https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h File webrtc/modules/audio_device/android/audio_device_template.h (right): https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h#newcode47 webrtc/modules/audio_device/android/audio_device_template.h:47: virtual ~AudioDeviceTemplate() { LOG(INFO) << ...
4 years, 5 months ago (2016-06-27 07:42:54 UTC) #4
Max Morin WebRTC
https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h File webrtc/modules/audio_device/android/audio_device_template.h (right): https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h#newcode47 webrtc/modules/audio_device/android/audio_device_template.h:47: virtual ~AudioDeviceTemplate() { LOG(INFO) << __FUNCTION__; } On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 13:05:47 UTC) #5
Max Morin WebRTC
4 years, 5 months ago (2016-06-27 13:07:22 UTC) #6
henrika_webrtc
https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h File webrtc/modules/audio_device/android/audio_device_template.h (right): https://codereview.webrtc.org/2091803002/diff/1/webrtc/modules/audio_device/android/audio_device_template.h#newcode47 webrtc/modules/audio_device/android/audio_device_template.h:47: virtual ~AudioDeviceTemplate() { LOG(INFO) << __FUNCTION__; } On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 13:15:42 UTC) #7
Max Morin WebRTC
4 years, 5 months ago (2016-06-27 13:46:24 UTC) #8
henrika_webrtc
LGTM
4 years, 5 months ago (2016-06-27 14:05:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2091803002/40001
4 years, 5 months ago (2016-06-27 14:05:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14496)
4 years, 5 months ago (2016-06-27 14:12:51 UTC) #13
Max Morin WebRTC
4 years, 5 months ago (2016-06-28 07:36:46 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
098e6c5d0a07a767c97dea14a2ebfc13b1ee23aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698