Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2091773002: Revert of Support GL_SAMPLES queries in null contexts (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, csmartdalton
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Support GL_SAMPLES queries in null contexts (patchset #4 id:60001 of https://codereview.chromium.org/2085043002/ ) Reason for revert: ASAN failures (including DEPS roll). Original issue's description: > Support GL_SAMPLES queries in null contexts > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002 > > Committed: https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521 > Committed: https://skia.googlesource.com/skia/+/57e98530c113066c4c2d9c64505c52dc25e66c00 TBR=bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/37feccb0bb858d7d970600ff97e48f540954fc6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -451 lines) Patch
M src/gpu/gl/GrGLCreateNullInterface.cpp View 13 chunks +86 lines, -363 lines 0 comments Download
M tools/gpu/gl/debug/DebugGLTestContext.cpp View 4 chunks +3 lines, -78 lines 0 comments Download
M tools/gpu/gl/debug/GrFBBindableObj.h View 2 chunks +1 line, -5 lines 0 comments Download
M tools/gpu/gl/debug/GrRenderBufferObj.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Support GL_SAMPLES queries in null contexts
4 years, 6 months ago (2016-06-23 13:11:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091773002/1
4 years, 6 months ago (2016-06-23 13:11:46 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 13:11:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/37feccb0bb858d7d970600ff97e48f540954fc6b

Powered by Google App Engine
This is Rietveld 408576698