third_party/WebKit/Source/modules/webusb/USBDevice.cpp - Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +#include for build fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

index 6275896a209a750651b33d22e9caf436e89428e1..bca0a3036ea23d6e03d63d5b49c7ee0b13301c8b 100644

--- a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

@@ -94,7 +94,7 @@ USBDevice::USBDevice(usb::DeviceInfoPtr deviceInfo, usb::DevicePtr device, Execu

, m_configurationIndex(-1)

{

if (m_device)

- m_device.set_connection_error_handler(createBaseCallback(bind(&USBDevice::onConnectionError, WeakPersistentThisPointer<USBDevice>(this))));

+ m_device.set_connection_error_handler(createBaseCallback(bind(&USBDevice::onConnectionError, wrapWeakPersistent(this))));

int configurationIndex = findConfigurationIndex(info().active_configuration);

if (configurationIndex != -1)

onConfigurationSelected(true /* success */, configurationIndex);

« no previous file with comments | « third_party/WebKit/Source/modules/webusb/USB.cpp ('k') | third_party/WebKit/Source/platform/CrossThreadCopier.h » ('j') | no next file with comments »