third_party/WebKit/Source/modules/webusb/USB.cpp - Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.cpp

Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +#include for build fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webusb/USBDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webusb/USB.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USB.cpp b/third_party/WebKit/Source/modules/webusb/USB.cpp

index d1461fb9d306db3d38b1c04de62915d541984c2c..f06ac114c46066dad206ec99de7a99f1ac35eeb6 100644

--- a/third_party/WebKit/Source/modules/webusb/USB.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USB.cpp

@@ -56,7 +56,7 @@ USB::USB(LocalFrame& frame)

{

ThreadState::current()->registerPreFinalizer(this);

frame.serviceRegistry()->connectToRemoteService(mojo::GetProxy(&m_deviceManager));

- m_deviceManager.set_connection_error_handler(createBaseCallback(bind(&USB::onDeviceManagerConnectionError, WeakPersistentThisPointer<USB>(this))));

+ m_deviceManager.set_connection_error_handler(createBaseCallback(bind(&USB::onDeviceManagerConnectionError, wrapWeakPersistent(this))));

m_deviceManager->SetClient(m_clientBinding.CreateInterfacePtrAndBind());

}

@@ -106,7 +106,7 @@ ScriptPromise USB::requestDevice(ScriptState* scriptState, const USBDeviceReques

return promise;

}

frame->serviceRegistry()->connectToRemoteService(mojo::GetProxy(&m_chooserService));

- m_chooserService.set_connection_error_handler(createBaseCallback(bind(&USB::onChooserServiceConnectionError, WeakPersistentThisPointer<USB>(this))));

+ m_chooserService.set_connection_error_handler(createBaseCallback(bind(&USB::onChooserServiceConnectionError, wrapWeakPersistent(this))));

}

String errorMessage;