Issue 2091693003: Correctly fallback to caret bounds when composition_head is not provided

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2091693003: Correctly fallback to caret bounds when composition_head is not provided (Closed)

Created:
4 years, 6 months ago by oshima

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Correctly fallback to caret bounds when composition_head is not provided BUG=622448 TEST=manual Review-Url: https://codereview.chromium.org/2089783004 Cr-Commit-Position: refs/heads/master@{#401485} (cherry picked from commit a517f584d88458b14aac79589a515e7d8c58665d) Committed: https://chromium.googlesource.com/chromium/src/+/3ac17c23b18c70166b05f8631974897e65cc53d9

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	ui/base/ime/input_method_chromeos.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

oshima

4 years, 6 months ago (2016-06-23 21:07:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ac17c23b18c70166b05f8631974897e65cc53d9 (tree was closed).